From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TiM2R-0005VX-JL for barebox@lists.infradead.org; Tue, 11 Dec 2012 09:22:10 +0000 Date: Tue, 11 Dec 2012 10:22:05 +0100 From: Sascha Hauer Message-ID: <20121211092205.GP10369@pengutronix.de> References: <1355127255-24797-1-git-send-email-w.sang@pengutronix.de> <1355127255-24797-2-git-send-email-w.sang@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1355127255-24797-2-git-send-email-w.sang@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 01/10] mtd: move is_power_of_2() to a public place To: Wolfram Sang Cc: barebox@lists.infradead.org On Mon, Dec 10, 2012 at 09:14:06AM +0100, Wolfram Sang wrote: > Will need this later for ubiformat. > > Signed-off-by: Wolfram Sang We already have it in a public place: include/linux/log2.h Sascha > --- > drivers/mtd/ubi/ubi-barebox.h | 5 +---- > include/mtd/utils.h | 25 +++++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 4 deletions(-) > create mode 100644 include/mtd/utils.h > > diff --git a/drivers/mtd/ubi/ubi-barebox.h b/drivers/mtd/ubi/ubi-barebox.h > index 72f29a6..919dc50 100644 > --- a/drivers/mtd/ubi/ubi-barebox.h > +++ b/drivers/mtd/ubi/ubi-barebox.h > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #define crc32(seed, data, length) crc32_no_comp(seed, (unsigned char const *)data, length) > > @@ -53,10 +54,6 @@ do { \ > #define put_device(...) > #define ubi_sysfs_init(...) 0 > #define ubi_sysfs_close(...) do { } while (0) > -static inline int is_power_of_2(unsigned long n) > -{ > - return (n != 0 && ((n & (n - 1)) == 0)); > -} > > /* FIXME */ > #define MKDEV(...) 0 > diff --git a/include/mtd/utils.h b/include/mtd/utils.h > new file mode 100644 > index 0000000..229fb34 > --- /dev/null > +++ b/include/mtd/utils.h > @@ -0,0 +1,25 @@ > +/* > + * mtd/utils.h - helper functions for various MTD utilities > + * > + * Copyright (C) 2012 by Wolfram Sang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#ifndef INCLUDE_MTD_UTILS_H > +# define INCLUDE_MTD_UTILS_H > + > +static inline int is_power_of_2(unsigned long n) > +{ > + return (n != 0 && ((n & (n - 1)) == 0)); > +} > + > +#endif /* INCLUDE_MTD_UTILS_H */ > -- > 1.7.10.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox