From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] nand: mxs: NO_SUBPAGE_WRITE flag was overwritten
Date: Wed, 19 Dec 2012 10:27:33 +0100 [thread overview]
Message-ID: <20121219092733.GZ26326@pengutronix.de> (raw)
In-Reply-To: <1355758617-21175-1-git-send-email-w.sang@pengutronix.de>
On Mon, Dec 17, 2012 at 04:36:57PM +0100, Wolfram Sang wrote:
> It is not the chip, but this controller which cannot do subpage writes.
> So, make sure we add the flag at the proper place, so it doesn't get
> overwritten by flash detection anymore.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Applied, thanks
Sascha
> ---
> drivers/mtd/nand/nand_mxs.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
> index c4509d3..bc34526 100644
> --- a/drivers/mtd/nand/nand_mxs.c
> +++ b/drivers/mtd/nand/nand_mxs.c
> @@ -1217,7 +1217,6 @@ static int mxs_nand_probe(struct device_d *dev)
> mtd->parent = dev;
>
> nand->priv = nand_info;
> - nand->options |= NAND_NO_SUBPAGE_WRITE;
>
> nand->cmd_ctrl = mxs_nand_cmd_ctrl;
>
> @@ -1241,8 +1240,15 @@ static int mxs_nand_probe(struct device_d *dev)
> nand->ecc.bytes = 9;
> nand->ecc.size = 512;
>
> - /* Scan to find existence of the device */
> - err = nand_scan(mtd, 1);
> + /* first scan to find the device and get the page size */
> + err = nand_scan_ident(mtd, 1);
> + if (err)
> + goto err2;
> +
> + nand->options |= NAND_NO_SUBPAGE_WRITE;
> +
> + /* second phase scan */
> + err = nand_scan_tail(mtd);
> if (err)
> goto err2;
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-19 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:36 Wolfram Sang
2012-12-19 9:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219092733.GZ26326@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox