From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Ty6mV-0005uD-03 for barebox@lists.infradead.org; Wed, 23 Jan 2013 20:18:47 +0000 Date: Wed, 23 Jan 2013 21:18:44 +0100 From: Sascha Hauer Message-ID: <20130123201844.GY1906@pengutronix.de> References: <1358257730-20579-1-git-send-email-alex.aring@gmail.com> <1358257730-20579-9-git-send-email-alex.aring@gmail.com> <20130117095431.GB1906@pengutronix.de> <20130123200134.GA3427@x61s.8.8.8.8> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130123200134.GA3427@x61s.8.8.8.8> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 8/8] memtest: add rewritten memtest command To: Alexander Aring Cc: barebox@lists.infradead.org Hi Alexander, On Wed, Jan 23, 2013 at 09:01:36PM +0100, Alexander Aring wrote: > > > +/* > > > + * PTE flags variables to set cached and > > > + * uncached regions. > > > + */ > > > +static uint32_t PTE_FLAGS_CACHED; > > > +static uint32_t PTE_FLAGS_UNCACHED; > > > > Please no uppercase letters for variable names. > > > Ok. I took it from mach/arm/cpu/mmu.c, should I create a patch which > rename it in arch/arm/cpu/mmu.c lower case, too? Yes, that would be great. I must have forgotten reviewing my own patch ;) > > > > +#else > > > +static char optstr[] = "s:e:i:b"; > > > +#endif > > > + > > > +/* > > > + * Perform a memory test. The complete test > > > + * loops until interrupted by ctrl-c. > > > + */ > > > +static int mem_test(vu_long _start, vu_long _end, > > > + int bus_only) > > > > It would be good to move this function to common/memory_test.c. This way > > it could be called from C. Especially testing memory might be called > > from some early small (no shell) development binaries which are running from some > > internal SRAM. > > > Ok. > Maybe we can do a menu entry via Kconfig or something else to run a > memtest after booting automatically. Maybe this could be added as an init script in the environment, but personally I don't think I'll run it by default on our boards. We are more into booting fast. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox