From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: reset: add shutdown_barebox() before reset_cpu()
Date: Wed, 30 Jan 2013 22:23:11 +0100 [thread overview]
Message-ID: <20130130212311.GC1906@pengutronix.de> (raw)
In-Reply-To: <1359457385-24232-1-git-send-email-antonynpavlov@gmail.com>
On Tue, Jan 29, 2013 at 03:03:05PM +0400, Antony Pavlov wrote:
> Some of controlled by barebox peripheral devices may be
> not affected by CPU reset, so we need call shutdown_barebox()
> to stop them.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> commands/reset.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/commands/reset.c b/commands/reset.c
> index 835926b..79885f4 100644
> --- a/commands/reset.c
> +++ b/commands/reset.c
> @@ -20,17 +20,40 @@
> #include <common.h>
> #include <command.h>
> #include <complete.h>
> +#include <getopt.h>
>
> static int cmd_reset(int argc, char *argv[])
> {
> + int opt, shutdown_flag;
> +
> + shutdown_flag = 1;
> +
> + while ((opt = getopt(argc, argv, "f")) > 0) {
> + switch (opt) {
> + case 'f':
> + shutdown_flag = 0;
> + break;
> + }
> + }
> +
> + if (shutdown_flag)
> + shutdown_barebox();
> +
> reset_cpu(0);
>
> /* Not reached */
> return 1;
> }
>
> +BAREBOX_CMD_HELP_START(reset)
> +BAREBOX_CMD_HELP_USAGE("reset [-f]\n")
> +BAREBOX_CMD_HELP_SHORT("Perform RESET of the CPU.\n")
> +BAREBOX_CMD_HELP_OPT("-f", "force RESET, don't call shutdown\n")
> +BAREBOX_CMD_HELP_END
> +
> BAREBOX_CMD_START(reset)
> .cmd = cmd_reset,
> .usage = "Perform RESET of the CPU",
> + BAREBOX_CMD_HELP(cmd_reset_help)
> BAREBOX_CMD_COMPLETE(empty_complete)
> BAREBOX_CMD_END
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-01-30 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:03 Antony Pavlov
2013-01-30 21:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130212311.GC1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox