mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] at91sam9*: use gpio_request_output()
Date: Thu, 31 Jan 2013 20:33:55 +0100	[thread overview]
Message-ID: <20130131193355.GH26329@game.jcrosoft.org> (raw)
In-Reply-To: <1359660567-12220-4-git-send-email-antonynpavlov@gmail.com>

On 23:29 Thu 31 Jan     , Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  arch/arm/boards/at91sam9261ek/init.c  |   18 +-----------------
>  arch/arm/boards/at91sam9263ek/init.c  |   18 +-----------------
>  arch/arm/boards/at91sam9m10ihd/init.c |   18 +-----------------
>  3 files changed, 3 insertions(+), 51 deletions(-)
> 
> diff --git a/arch/arm/boards/at91sam9261ek/init.c b/arch/arm/boards/at91sam9261ek/init.c
> index 2597ff8..220dd2f 100644
> --- a/arch/arm/boards/at91sam9261ek/init.c
> +++ b/arch/arm/boards/at91sam9261ek/init.c
> @@ -153,22 +153,6 @@ static void ek_add_device_udc(void) {}
>   * LCD Controller
>   */
>  #if defined(CONFIG_DRIVER_VIDEO_ATMEL)
> -static int ek_gpio_request_output(int gpio, const char *name)
> -{
> -	int ret;
> -
> -	ret = gpio_request(gpio, name);
> -	if (ret) {
> -		pr_err("%s: can not request gpio %d (%d)\n", name, gpio, ret);
> -		return ret;
> -	}
> -
> -	ret = gpio_direction_output(gpio, 1);
> -	if (ret)
> -		pr_err("%s: can not configure gpio %d as output (%d)\n", name, gpio, ret);
> -	return ret;
> -}
> -
>  /* TFT */
>  static struct fb_videomode at91_tft_vga_modes[] = {
>  	{
> @@ -211,7 +195,7 @@ static struct atmel_lcdfb_platform_data ek_lcdc_data = {
>  
>  static int at91_lcdc_gpio(void)
>  {
> -	return ek_gpio_request_output(AT91_PIN_PA12, "lcdc_tft_power");
> +	return gpio_request_output(AT91_PIN_PA12, "lcdc_tft_power", 1);
>  }
>  
>  static void ek_add_device_lcdc(void)
> diff --git a/arch/arm/boards/at91sam9263ek/init.c b/arch/arm/boards/at91sam9263ek/init.c
> index 6db6a5b..1287c23 100644
> --- a/arch/arm/boards/at91sam9263ek/init.c
> +++ b/arch/arm/boards/at91sam9263ek/init.c
> @@ -153,22 +153,6 @@ static void ek_add_device_udc(void) {}
>   * LCD Controller
>   */
>  #if defined(CONFIG_DRIVER_VIDEO_ATMEL)
> -static int ek_gpio_request_output(int gpio, const char *name)
> -{
> -	int ret;
> -
> -	ret = gpio_request(gpio, name);
> -	if (ret) {
> -		pr_err("%s: can not request gpio %d (%d)\n", name, gpio, ret);
> -		return ret;
> -	}
> -
> -	ret = gpio_direction_output(gpio, 1);
> -	if (ret)
> -		pr_err("%s: can not configure gpio %d as output (%d)\n", name, gpio, ret);
> -	return ret;
> -}
> -
>  static struct fb_videomode at91_tft_vga_modes[] = {
>  	{
>  		.name		= "TX09D50VM1CCA @ 60",
> @@ -208,7 +192,7 @@ static struct atmel_lcdfb_platform_data ek_lcdc_data = {
>  
>  static void ek_add_device_lcdc(void)
>  {
> -	if (ek_gpio_request_output(AT91_PIN_PA30, "lcdc_power"))
> +	if (gpio_request_output(AT91_PIN_PA30, "lcdc_power", 1))
>  		return;
>  
>  	at91_add_device_lcdc(&ek_lcdc_data);
> diff --git a/arch/arm/boards/at91sam9m10ihd/init.c b/arch/arm/boards/at91sam9m10ihd/init.c
> index 325a250..859ee1f 100644
> --- a/arch/arm/boards/at91sam9m10ihd/init.c
> +++ b/arch/arm/boards/at91sam9m10ihd/init.c
> @@ -174,22 +174,6 @@ static int at91sam9m10g45ek_mem_init(void)
>  mem_initcall(at91sam9m10g45ek_mem_init);
>  
>  #if defined(CONFIG_DRIVER_VIDEO_ATMEL)
> -static int ek_gpio_request_output(int gpio, const char *name)
> -{
> -	int ret;
> -
> -	ret = gpio_request(gpio, name);
> -	if (ret) {
> -		pr_err("%s: can not request gpio %d (%d)\n", name, gpio, ret);
> -		return ret;
> -	}
> -
> -	ret = gpio_direction_output(gpio, 1);
> -	if (ret)
> -		pr_err("%s: can not configure gpio %d as output (%d)\n", name, gpio, ret);
> -	return ret;
> -}
> -
>  static struct fb_videomode at91fb_default_monspecs[] = {
>  	{
>  		.name		= "MULTEK",
> @@ -229,7 +213,7 @@ static struct atmel_lcdfb_platform_data ek_lcdc_data = {
>  
>  static void ek_add_device_lcd(void)
>  {
> -	if (ek_gpio_request_output(AT91_PIN_PE6, "lcdc_power"))
> +	if (gpio_request_output(AT91_PIN_PE6, "lcdc_power", 1))
we loose the error messages

NACK

Best Regards,
J.
>  		return;
>  
>  	at91_add_device_lcdc(&ek_lcdc_data);
> -- 
> 1.7.10.4
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-01-31 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 19:29 [PATCH 0/4] gpiolib: add gpio_request_{in,out}put support Antony Pavlov
2013-01-31 19:29 ` [PATCH 1/4] gpiolib: fix whitespaces Antony Pavlov
2013-01-31 19:29 ` [PATCH 2/4] gpiolib: add gpio_request_{in,out}put support Antony Pavlov
2013-01-31 19:29 ` [PATCH 3/4] at91sam9*: use gpio_request_output() Antony Pavlov
2013-01-31 19:33   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-01-31 19:29 ` [PATCH 4/4] animeo_ip: use gpio_request_input() Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130131193355.GH26329@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox