From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] at91sam9_ddrsdr: fix register on mdr read and sdram detection for ddr size
Date: Mon, 4 Feb 2013 09:45:08 +0100 [thread overview]
Message-ID: <20130204084508.GD1906@pengutronix.de> (raw)
In-Reply-To: <1359899398-3867-1-git-send-email-plagnioj@jcrosoft.com>
On Sun, Feb 03, 2013 at 02:49:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> it's currently working by luck
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> v2:
> 2 bug together make it work
>
Applied, thanks
Sascha
> Best Regards,
> J.
> arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h b/arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> index 2614f97..88796a6 100644
> --- a/arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> +++ b/arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> @@ -146,7 +146,7 @@ static inline u32 at91_get_ddram_size(void * __iomem base, bool is_nb)
> bool is_sdram;
>
> cr = __raw_readl(base + AT91_DDRSDRC_CR);
> - mdr = __raw_readl(base + AT91_DDRSDRC_CR);
> + mdr = __raw_readl(base + AT91_DDRSDRC_MDR);
>
> is_sdram = (mdr & AT91_DDRSDRC_MD) <= AT91_DDRSDRC_MD_LOW_POWER_SDR;
>
> @@ -158,7 +158,7 @@ static inline u32 at91_get_ddram_size(void * __iomem base, bool is_nb)
> size = 1;
> /* COL */
> size += (cr & AT91_DDRSDRC_NC) + 8;
> - if (is_sdram)
> + if (!is_sdram)
> size ++;
> /* ROW */
> size += ((cr & AT91_DDRSDRC_NR) >> 2) + 11;
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-04 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 12:48 [PATCH 1/1] at91sam9_ddrsdr: fix register on mdr read " Jean-Christophe PLAGNIOL-VILLARD
2013-02-03 13:49 ` [PATCH v2] at91sam9_ddrsdr: fix register on mdr read and sdram detection " Jean-Christophe PLAGNIOL-VILLARD
2013-02-04 8:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204084508.GD1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox