mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: pbl: fix none compression support
Date: Tue, 5 Feb 2013 09:44:04 +0100	[thread overview]
Message-ID: <20130205084404.GM1906@pengutronix.de> (raw)
In-Reply-To: <1360008030-4169-1-git-send-email-antonynpavlov@gmail.com>

On Tue, Feb 05, 2013 at 12:00:30AM +0400, Antony Pavlov wrote:
> Here's the error message:
> 
>   AS      arch/mips/pbl/piggy.shipped.o
>   arch/mips/pbl/piggy.shipped.S: Assembler messages:
>   arch/mips/pbl/piggy.shipped.S:1: Error: unrecognized opcode `globl input_data'
>   make[1]: *** [arch/mips/pbl/piggy.shipped.o] Error 1
>   make: *** [zbarebox.bin] Error 2
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  arch/mips/pbl/piggy.shipped.S |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/mips/pbl/piggy.shipped.S b/arch/mips/pbl/piggy.shipped.S
> index 963262d..8a35f6b 100644
> --- a/arch/mips/pbl/piggy.shipped.S
> +++ b/arch/mips/pbl/piggy.shipped.S
> @@ -1,6 +1,6 @@
> -	.section .piggydata,#alloc
> -	.globl  input_data
> -input_data:
> -	.incbin "arch/mips/pbl/piggy.shipped"
> -	.globl  input_data_end
> -input_data_end:
> +#include <asm/asm.h>
> +
> +	.section .data
> +EXPORT(input_data)
> +	.incbin	"arch/mips/pbl/piggy.shipped"
> +EXPORT(input_data_end)
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-02-05  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 20:00 Antony Pavlov
2013-02-05  8:44 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130205084404.GM1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox