From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] pbl: factorise linux/decompress/mm.h inclusion
Date: Tue, 5 Feb 2013 09:57:13 +0100 [thread overview]
Message-ID: <20130205085713.GO1906@pengutronix.de> (raw)
In-Reply-To: <1360017396-13321-2-git-send-email-antonynpavlov@gmail.com>
On Tue, Feb 05, 2013 at 02:36:36AM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> lib/decompress_inflate.c | 1 -
> lib/decompress_unlzo.c | 1 -
> pbl/decomp.c | 2 ++
> 3 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/decompress_inflate.c b/lib/decompress_inflate.c
> index 5c1ebb6..526d6a1 100644
> --- a/lib/decompress_inflate.c
> +++ b/lib/decompress_inflate.c
> @@ -4,7 +4,6 @@
> /* prevent inclusion of _LINUX_KERNEL_H in pre-boot environment: lots
> * errors about console_printk etc... on ARM */
> #define _LINUX_KERNEL_H
> -#include <linux/decompress/mm.h>
>
> #include "zlib_inflate/inftrees.c"
> #include "zlib_inflate/inffast.c"
> diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c
> index 1b2dc9d..2b0fbed 100644
> --- a/lib/decompress_unlzo.c
> +++ b/lib/decompress_unlzo.c
> @@ -32,7 +32,6 @@
> #include <xfuncs.h>
>
> #ifdef STATIC
> -#include <linux/decompress/mm.h>
> #include "lzo/lzo1x_decompress.c"
> #else
> #include <malloc.h>
> diff --git a/pbl/decomp.c b/pbl/decomp.c
> index aa6a31e..17fc01e 100644
> --- a/pbl/decomp.c
> +++ b/pbl/decomp.c
> @@ -10,6 +10,8 @@
>
> #define STATIC static
>
> +#include <linux/decompress/mm.h>
> +
Any special reason for this patch? Normally the #include is in the file
requiring the declarations from the file. In this case decompress_* need
linux/decompress/mm.h, not pbl/decomp.c.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-05 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 22:36 [PATCH 1/2] pbl: fix IMAGE_COMPRESSION_LZO-enabled build on MIPS Antony Pavlov
2013-02-04 22:36 ` [PATCH 2/2] pbl: factorise linux/decompress/mm.h inclusion Antony Pavlov
2013-02-05 8:57 ` Sascha Hauer [this message]
2013-02-05 9:07 ` Antony Pavlov
2013-02-05 8:58 ` [PATCH 1/2] pbl: fix IMAGE_COMPRESSION_LZO-enabled build on MIPS Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205085713.GO1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox