From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 01/11] ARM: clps711x: Move lowlevel initialization in common CLPS711X location
Date: Mon, 11 Feb 2013 09:48:40 +0100 [thread overview]
Message-ID: <20130211084840.GM1906@pengutronix.de> (raw)
In-Reply-To: <1360317743-25975-1-git-send-email-shc_work@mail.ru>
On Fri, Feb 08, 2013 at 02:02:13PM +0400, Alexander Shiyan wrote:
> One lowlevel initialization will be used on any CLPS711X-target,
> so move it in the common location.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boards/clep7212/Makefile | 3 +-
> arch/arm/boards/clep7212/lowlevel.c | 57 -----------------------------------
> arch/arm/mach-clps711x/Makefile | 3 +-
> arch/arm/mach-clps711x/lowlevel.c | 57 +++++++++++++++++++++++++++++++++++
> 4 files changed, 60 insertions(+), 60 deletions(-)
> delete mode 100644 arch/arm/boards/clep7212/lowlevel.c
> create mode 100644 arch/arm/mach-clps711x/lowlevel.c
>
> diff --git a/arch/arm/boards/clep7212/Makefile b/arch/arm/boards/clep7212/Makefile
> index a63aeae..676e867 100644
> --- a/arch/arm/boards/clep7212/Makefile
> +++ b/arch/arm/boards/clep7212/Makefile
> @@ -1,2 +1 @@
> -obj-y += lowlevel.o clep7212.o
> -pbl-y += lowlevel.o
> +obj-y += clep7212.o
> diff --git a/arch/arm/boards/clep7212/lowlevel.c b/arch/arm/boards/clep7212/lowlevel.c
I think it's better to keep the reset vector in board specific code.
Then you can have a board specific reset vector, which simply calls
a SoC specific one. This also solves the Kconfig problem with the
PLL setup. So you would have this in your board:
void __naked __bare_init barebox_arm_reset_vector(void)
{
arm_cpu_lowlevel_init();
clps711x_barebox_entry();
}
You could add different more specific clps711x_* functions which will
result in different CPU speeds, or you could pass a PLL value to the
entry function, if that better fits your needs.
The rest of this series looks fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-11 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 10:02 Alexander Shiyan
2013-02-08 10:02 ` [PATCH 02/11] ARM: clps711x: Fix SDRAM setup comment Alexander Shiyan
2013-02-08 10:02 ` [PATCH 03/11] ARM: clps711x: Adds config option for CPU PLL multiplier Alexander Shiyan
2013-02-08 11:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 11:58 ` Re[2]: " Alexander Shiyan
2013-02-08 13:37 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 10:02 ` [PATCH 04/11] ARM: clps711x: Decrease initial memory size to 8MB Alexander Shiyan
2013-02-08 10:02 ` [PATCH 05/11] ARM: clps711x: Remove unused "start" declaration from reset.c Alexander Shiyan
2013-02-08 10:02 ` [PATCH 06/11] ARM: clps711x: Mark private functions that not will be used outside as static Alexander Shiyan
2013-02-08 10:02 ` [PATCH 07/11] ARM: clep7212: Fix NULL pointer exception if MMU is enabled Alexander Shiyan
2013-02-08 10:02 ` [PATCH 08/11] ARM: mmu: Clear unpredictable bits for translation table Alexander Shiyan
2013-02-11 8:26 ` Sascha Hauer
2013-02-08 10:02 ` [PATCH 09/11] ARM: clps711x: Move memory initialization in common CLPS711X location Alexander Shiyan
2013-02-08 10:02 ` [PATCH 10/11] ARM: clps711x: Turn off all peripherals on startup Alexander Shiyan
2013-02-08 10:02 ` [PATCH 11/11] ARM: clps711x: Update defconfig Alexander Shiyan
2013-02-11 8:48 ` Sascha Hauer [this message]
2013-02-11 9:30 ` Re[2]: [PATCH 01/11] ARM: clps711x: Move lowlevel initialization in common CLPS711X location Alexander Shiyan
2013-02-11 9:41 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211084840.GM1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox