From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U4p46-0000cl-Cd for barebox@lists.infradead.org; Mon, 11 Feb 2013 08:48:43 +0000 Date: Mon, 11 Feb 2013 09:48:40 +0100 From: Sascha Hauer Message-ID: <20130211084840.GM1906@pengutronix.de> References: <1360317743-25975-1-git-send-email-shc_work@mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1360317743-25975-1-git-send-email-shc_work@mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 01/11] ARM: clps711x: Move lowlevel initialization in common CLPS711X location To: Alexander Shiyan Cc: barebox@lists.infradead.org On Fri, Feb 08, 2013 at 02:02:13PM +0400, Alexander Shiyan wrote: > One lowlevel initialization will be used on any CLPS711X-target, > so move it in the common location. > > Signed-off-by: Alexander Shiyan > --- > arch/arm/boards/clep7212/Makefile | 3 +- > arch/arm/boards/clep7212/lowlevel.c | 57 ----------------------------------- > arch/arm/mach-clps711x/Makefile | 3 +- > arch/arm/mach-clps711x/lowlevel.c | 57 +++++++++++++++++++++++++++++++++++ > 4 files changed, 60 insertions(+), 60 deletions(-) > delete mode 100644 arch/arm/boards/clep7212/lowlevel.c > create mode 100644 arch/arm/mach-clps711x/lowlevel.c > > diff --git a/arch/arm/boards/clep7212/Makefile b/arch/arm/boards/clep7212/Makefile > index a63aeae..676e867 100644 > --- a/arch/arm/boards/clep7212/Makefile > +++ b/arch/arm/boards/clep7212/Makefile > @@ -1,2 +1 @@ > -obj-y += lowlevel.o clep7212.o > -pbl-y += lowlevel.o > +obj-y += clep7212.o > diff --git a/arch/arm/boards/clep7212/lowlevel.c b/arch/arm/boards/clep7212/lowlevel.c I think it's better to keep the reset vector in board specific code. Then you can have a board specific reset vector, which simply calls a SoC specific one. This also solves the Kconfig problem with the PLL setup. So you would have this in your board: void __naked __bare_init barebox_arm_reset_vector(void) { arm_cpu_lowlevel_init(); clps711x_barebox_entry(); } You could add different more specific clps711x_* functions which will result in different CPU speeds, or you could pass a PLL value to the entry function, if that better fits your needs. The rest of this series looks fine. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox