From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [For master PATCH 1/1] sama5de3k: add gmacb support
Date: Mon, 11 Feb 2013 12:35:19 +0100 [thread overview]
Message-ID: <20130211113519.GW19322@game.jcrosoft.org> (raw)
In-Reply-To: <20130211083040.GK1906@pengutronix.de>
On 09:30 Mon 11 Feb , Sascha Hauer wrote:
> On Fri, Feb 08, 2013 at 10:28:44AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > arch/arm/boards/sama5d3xek/init.c | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
>
> Applied, thanks.
>
> > +static int ksz9021rn_phy_fixup(struct phy_device *phy)
> > +{
> > + int value;
> > +
> > +#define GMII_RCCPSR 260
> > +#define GMII_RRDPSR 261
> > +#define GMII_ERCR 11
> > +#define GMII_ERDWR 12
> > +
> > + /* Set delay values */
> > + value = GMII_RCCPSR | 0x8000;
> > + phy_write(phy, GMII_ERCR, value);
> > + value = 0xF2F4;
> > + phy_write(phy, GMII_ERDWR, value);
> > + value = GMII_RRDPSR | 0x8000;
> > + phy_write(phy, GMII_ERCR, value);
> > + value = 0x2222;
> > + phy_write(phy, GMII_ERDWR, value);
> > +
> > + return 0;
>
> This delay line setup really needs some generic code. We have this on
> i.MX6 aswell. Currently this means that each board needs to know the
> phy it has, not a really good situation.
the pb that it's hardware specific (PCB layout) so I do not see how we can fix
this
Best Regards,
J.
>
> Sascha
>
> > +}
> > +
> > static void ek_add_device_eth(void)
> > {
> > if (w1_local_mac_address_register(0, "tml", "w1-2d-0"))
> > @@ -147,6 +174,10 @@ static void ek_add_device_eth(void)
> > if (ek_register_mac_address_23(1))
> > ek_register_mac_address_43(1);
> >
> > + phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK,
> > + ksz9021rn_phy_fixup);
> > +
> > + at91_add_device_eth(0, &gmac_pdata);
> > at91_add_device_eth(1, &macb_pdata);
> > }
> > #else
> > --
> > 1.7.10.4
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-11 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 9:25 [PATCH 0/1] sama5d3xek: add GEM Gigabig support Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 9:28 ` [For master PATCH 1/1] sama5de3k: add gmacb support Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 10:24 ` Nicolas Ferre
2013-02-11 8:30 ` Sascha Hauer
2013-02-11 11:35 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-11 12:14 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211113519.GW19322@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox