mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH 2/6] of: make of_add_memory available for other board
Date: Wed, 13 Feb 2013 18:59:37 +0100	[thread overview]
Message-ID: <20130213175937.GQ19322@game.jcrosoft.org> (raw)
In-Reply-To: <20130213173134.GG1906@pengutronix.de>

On 18:31 Wed 13 Feb     , Sascha Hauer wrote:
> On Wed, Feb 13, 2013 at 11:06:40AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > so when the first stage booloader of firmware provide the dtb
> > we can use it to probe the memory
> > 
> > also allow to print what we probe
> > 
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  drivers/of/base.c |   20 ++++++++++++++------
> >  include/of.h      |    6 ++++++
> >  2 files changed, 20 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > index 1f32bfb..f2986ab 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -734,18 +734,23 @@ u64 dt_mem_next_cell(int s, const __be32 **cellp)
> >  	return of_read_number(p, s);
> >  }
> >  
> > -static int of_add_memory(struct device_node *node)
> > +int of_add_memory(struct device_node *node, bool dump)
> >  {
> >  	int na, nc;
> >  	const __be32 *reg, *endp;
> >  	int len, r = 0;
> >  	static char str[6];
> > +	struct property *type;
> > +
> > +	type = of_find_property(node, "device_type");
> > +	if (!type)
> > +		return -ENXIO;
> 
> Could you add the missing check here if device_type is 'memory'?
ok

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-02-13 18:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 10:02 [PATCH 0/6 v3] arm: add Calxeda Highbank support Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06 ` [PATCH 1/6] ahci-generic: add oftree support Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06   ` [PATCH 2/6] of: make of_add_memory available for other board Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 17:31     ` Sascha Hauer
2013-02-13 17:59       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-13 18:09       ` [PATCH 1/1] of_add_memory: check the device_type is memory Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06   ` [PATCH 3/6] highbank: add xgmac support Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06   ` [PATCH 4/6] arm: add highbank support Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06   ` [PATCH 5/6] highbank: add l2x0 support Jean-Christophe PLAGNIOL-VILLARD
2013-02-13 10:06   ` [PATCH 6/6] highbank: use the provided dtb by the firmware to probe barebox device and mem size Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 13:47 ` [PATCH 0/6 v3] arm: add Calxeda Highbank support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213175937.GQ19322@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=rob.herring@calxeda.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox