mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org, Juergen Beisert <jbe@pengutronix.de>
Subject: Re: [PATCH 1/3] env: add register_persistent_environment
Date: Thu, 14 Feb 2013 20:31:35 +0100	[thread overview]
Message-ID: <20130214193135.GA1906@pengutronix.de> (raw)
In-Reply-To: <1360843011-7807-1-git-send-email-eric@eukrea.com>

On Thu, Feb 14, 2013 at 12:56:49PM +0100, Eric Bénard wrote:
> - heavily copied from register_persistant_environment which was
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  common/environment.c  | 40 ++++++++++++++++++++++++++++++++++++++++
>  include/environment.h |  1 +

Please move the prototype to include/envfs.h. include/environment.h has
stuff for shell environment variables only.

>  2 files changed, 41 insertions(+)
> 
> diff --git a/common/environment.c b/common/environment.c
> index e8d623f..55befd9 100644
> --- a/common/environment.c
> +++ b/common/environment.c
> @@ -363,3 +363,43 @@ out:
>  		free(buf_free);
>  	return ret;
>  }
> +
> +#ifdef __BAREBOX__
> +/**
> + * Try to register an environment storage on a device's partition
> + * @return 0 on success
> + *
> + * We rely on the existence of a usable storage device, already attached to
> + * our system, to get something like a persistent memory for our environment.
> + * We need to specify the partition number to use on this device.
> + * @param[in] devname Name of the device
> + * @param[in] partnr Partition number
> + * @return 0 on success, anything else in case of failure
> + */
> +
> +int register_persistent_environment(const char *devname, unsigned int partnr)

I think envfs_register_partition would be a better name.

> +{
> +	struct cdev *cdev;
> +	char *partname;
> +
> +	if (!devname)
> +		return -EINVAL;
> +
> +	cdev = cdev_by_name(devname);
> +	if (cdev == NULL) {
> +		pr_err("No %s present\n", devname);
> +		return -ENODEV;
> +	}
> +	partname = asprintf("%s.%d", devname, partnr);

free partname?

Sascha

> +	cdev = cdev_by_name(partname);
> +	if (cdev == NULL) {
> +		pr_err("No %s partition available\n", partname);
> +		pr_info("Please create the partition %s to store the env\n", partname);
> +		return -ENODEV;
> +	}
> +
> +	return devfs_add_partition(partname, 0, cdev->size,
> +						DEVFS_PARTITION_FIXED, "env0");
> +}
> +EXPORT_SYMBOL(register_persistent_environment);
> +#endif
> diff --git a/include/environment.h b/include/environment.h
> index 7bdd213..d172f8f 100644
> --- a/include/environment.h
> +++ b/include/environment.h
> @@ -71,6 +71,7 @@ int env_pop_context(void);
>  int env_push_context(void);
>  
>  int export(const char *);
> +int register_persistent_environment(const char *devname, unsigned int partnr);
>  
>  #endif	/* _ENVIRONMENT_H_ */
>  
> -- 
> 1.7.11.7
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-02-14 19:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 16:45 [PATCH 0/2] ARM: cfa10036: Store the barebox environment on the MMC Maxime Ripard
2013-02-13 16:45 ` [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment Maxime Ripard
2013-02-13 17:10   ` Eric Bénard
2013-02-13 17:12   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-14  9:52     ` Maxime Ripard
2013-02-14  8:16   ` Juergen Beisert
2013-02-14 10:10     ` Maxime Ripard
2013-02-14 11:17       ` Eric Bénard
2013-02-14 11:56         ` [PATCH 1/3] env: add register_persistent_environment Eric Bénard
2013-02-14 11:56           ` [PATCH 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-14 11:56           ` [PATCH 3/3] falconwing: switch " Eric Bénard
2013-02-14 12:09             ` Juergen Beisert
2013-02-14 13:20               ` [PATCH v2] " Eric Bénard
2013-02-14 13:50                 ` [PATCH v3] " Eric Bénard
2013-02-14 19:31           ` Sascha Hauer [this message]
2013-02-19  9:17             ` [PATCH v4 1/3] env: add register_persistent_environment Eric Bénard
2013-02-19  9:17               ` [PATCH v4 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-19  9:17               ` [PATCH v4 3/3] falconwing: switch " Eric Bénard
2013-02-19 11:58               ` [PATCH v4 1/3] env: add register_persistent_environment Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 13:41                 ` Eric Bénard
2013-02-19 15:35                   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 15:49                     ` Eric Bénard
2013-02-19 15:57                       ` Eric Bénard
2013-02-19 19:21                         ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21  6:55                           ` Eric Bénard
2013-02-21 11:20                             ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:52               ` Sascha Hauer
2013-02-13 16:45 ` [PATCH 2/2] cfa10036: Update the environment Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214193135.GA1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox