mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] Add Generic GPIO driver
Date: Tue, 19 Feb 2013 08:26:48 +0100	[thread overview]
Message-ID: <20130219072648.GU1906@pengutronix.de> (raw)
In-Reply-To: <1361257763.676618458@f254.mail.ru>

On Tue, Feb 19, 2013 at 11:09:23AM +0400, Alexander Shiyan wrote:
> > On Mon, Feb 18, 2013 at 02:13:22PM +0400, Alexander Shiyan wrote:
> > > > On Fri, Feb 15, 2013 at 10:49:27PM +0400, Alexander Shiyan wrote:
> > > > > This patch adds generic memory-mapped GPIO controller support.
> > > > > Code taken from Linux Kernel and adopted for barebox.
> > > > 
> > > > I'm fine with this if you add a user for it. I wonder though if it's
> > > > worth it to have this driver for barebox. If I have a driver in the
> > > > kernel that already uses it, then this makes it simple to copy it, but
> > > > should I have to write a new gpio driver, I'm unsure if it's simpler
> > > > to write a new gpio driver or to register with the generic gpio
> > > > driver.
> > > 
> > > Here's an example that I'm checking:
> > 
> > Ok, this indeed looks nice and short. You convinced me ;)
> > 
> > As said, I'm fine with the generic gpio driver if you add the below as
> > first user.
> 
> I still beg to consider patch for generic GPIO separately.
> Then I will send you two completely different versions of the implementation
> GPIO for CLPS711X for consideration.

I don't know if I'm misunderstanding you. Of course the generic GPIO
driver and the CLPS711x driver should be two separate patches, but
both should come in the same series. I just want to wait applying the
generic driver until we have a user (and thus compile coverage).

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-02-19  7:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 18:49 Alexander Shiyan
2013-02-18 10:06 ` Sascha Hauer
2013-02-18 10:13   ` Re[2]: " Alexander Shiyan
2013-02-18 10:19     ` Sascha Hauer
2013-02-19  7:09       ` Re[2]: " Alexander Shiyan
2013-02-19  7:26         ` Sascha Hauer [this message]
2013-02-19  7:34           ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130219072648.GU1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox