From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Rob Herring <rob.herring@calxeda.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] highbank: add wfi for poweroff
Date: Wed, 20 Feb 2013 15:22:59 +0100 [thread overview]
Message-ID: <20130220142259.GA5291@game.jcrosoft.org> (raw)
In-Reply-To: <5124D92C.9030308@calxeda.com>
On 08:09 Wed 20 Feb , Rob Herring wrote:
> On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > needed by the real hardware
> >
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > arch/arm/mach-highbank/reset.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> > index 630672a..b9664e4 100644
> > --- a/arch/arm/mach-highbank/reset.c
> > +++ b/arch/arm/mach-highbank/reset.c
> > @@ -23,5 +23,7 @@ void __noreturn poweroff()
> > shutdown_barebox();
> >
> > hingbank_set_pwr_shutdown();
> > + asm(" wfi");
> > +
>
> This will break on old compilers or v5 builds. I personally don't care,
> but some people do.
I do not care too
and highbank is a v7 so I expect you use the proper compiler
Best Regards,
J.
>
> Rob
>
> > while(1);
> > }
> >
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-20 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 12:55 Jean-Christophe PLAGNIOL-VILLARD
2013-02-20 14:09 ` Rob Herring
2013-02-20 14:22 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-21 13:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220142259.GA5291@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox