* [PATCH 1/1] highbank: add wfi for poweroff
@ 2013-02-20 12:55 Jean-Christophe PLAGNIOL-VILLARD
2013-02-20 14:09 ` Rob Herring
2013-02-21 13:23 ` Sascha Hauer
0 siblings, 2 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-02-20 12:55 UTC (permalink / raw)
To: barebox; +Cc: Rob Herring
needed by the real hardware
Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
arch/arm/mach-highbank/reset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
index 630672a..b9664e4 100644
--- a/arch/arm/mach-highbank/reset.c
+++ b/arch/arm/mach-highbank/reset.c
@@ -23,5 +23,7 @@ void __noreturn poweroff()
shutdown_barebox();
hingbank_set_pwr_shutdown();
+ asm(" wfi");
+
while(1);
}
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] highbank: add wfi for poweroff
2013-02-20 12:55 [PATCH 1/1] highbank: add wfi for poweroff Jean-Christophe PLAGNIOL-VILLARD
@ 2013-02-20 14:09 ` Rob Herring
2013-02-20 14:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:23 ` Sascha Hauer
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2013-02-20 14:09 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> needed by the real hardware
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> arch/arm/mach-highbank/reset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> index 630672a..b9664e4 100644
> --- a/arch/arm/mach-highbank/reset.c
> +++ b/arch/arm/mach-highbank/reset.c
> @@ -23,5 +23,7 @@ void __noreturn poweroff()
> shutdown_barebox();
>
> hingbank_set_pwr_shutdown();
> + asm(" wfi");
> +
This will break on old compilers or v5 builds. I personally don't care,
but some people do.
Rob
> while(1);
> }
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] highbank: add wfi for poweroff
2013-02-20 14:09 ` Rob Herring
@ 2013-02-20 14:22 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-02-20 14:22 UTC (permalink / raw)
To: Rob Herring; +Cc: barebox
On 08:09 Wed 20 Feb , Rob Herring wrote:
> On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > needed by the real hardware
> >
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > arch/arm/mach-highbank/reset.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> > index 630672a..b9664e4 100644
> > --- a/arch/arm/mach-highbank/reset.c
> > +++ b/arch/arm/mach-highbank/reset.c
> > @@ -23,5 +23,7 @@ void __noreturn poweroff()
> > shutdown_barebox();
> >
> > hingbank_set_pwr_shutdown();
> > + asm(" wfi");
> > +
>
> This will break on old compilers or v5 builds. I personally don't care,
> but some people do.
I do not care too
and highbank is a v7 so I expect you use the proper compiler
Best Regards,
J.
>
> Rob
>
> > while(1);
> > }
> >
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] highbank: add wfi for poweroff
2013-02-20 12:55 [PATCH 1/1] highbank: add wfi for poweroff Jean-Christophe PLAGNIOL-VILLARD
2013-02-20 14:09 ` Rob Herring
@ 2013-02-21 13:23 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2013-02-21 13:23 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox, Rob Herring
On Wed, Feb 20, 2013 at 01:55:36PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> needed by the real hardware
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-21 13:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-20 12:55 [PATCH 1/1] highbank: add wfi for poweroff Jean-Christophe PLAGNIOL-VILLARD
2013-02-20 14:09 ` Rob Herring
2013-02-20 14:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:23 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox