From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U8WpV-0002M9-9e for barebox@lists.infradead.org; Thu, 21 Feb 2013 14:08:57 +0000 Date: Thu, 21 Feb 2013 15:08:55 +0100 From: Sascha Hauer Message-ID: <20130221140855.GW1906@pengutronix.de> References: <1361265854-14224-1-git-send-email-plagnioj@jcrosoft.com> <20130221135600.GT1906@pengutronix.de> <20130221140142.GD5291@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130221140142.GD5291@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [For master PATCH 1/1] grapric_utils: set_pixel only write 16bit in 16bit mode To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Thu, Feb 21, 2013 at 03:01:42PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:56 Thu 21 Feb , Sascha Hauer wrote: > > On Tue, Feb 19, 2013 at 10:24:14AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > > --- > > > lib/gui/graphic_utils.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c > > > index 95687df..a1be5d0 100644 > > > --- a/lib/gui/graphic_utils.c > > > +++ b/lib/gui/graphic_utils.c > > > @@ -104,7 +104,7 @@ void set_pixel(struct fb_info *info, void *adr, u32 px) > > > case 8: > > > break; > > > case 16: > > > - *(u16 *)adr = px; > > > + *(u16 *)adr = px & 0xffff; > > > > What does this fix? The result should be the same. > not on qemu Isn't this a bug in qemu? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox