From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] phy: fix force mode
Date: Mon, 25 Feb 2013 08:55:10 +0100 [thread overview]
Message-ID: <20130225075510.GJ1906@pengutronix.de> (raw)
In-Reply-To: <1361698452-3167-1-git-send-email-plagnioj@jcrosoft.com>
On Sun, Feb 24, 2013 at 10:34:12AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> do not try to read the status in force mode
> the link is up
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks
Sascha
> ---
> drivers/net/phy/mdio_bus.c | 4 ++++
> drivers/net/phy/phy.c | 4 ++++
> include/linux/phy.h | 1 +
> 3 files changed, 9 insertions(+)
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index d1d802b..e1bb7b1 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -167,10 +167,14 @@ static int mdio_bus_probe(struct device_d *_dev)
> dev->speed = SPEED_10;
> dev->duplex = DUPLEX_FULL;
> dev->autoneg = !AUTONEG_ENABLE;
> + dev->force = 1;
> + dev->link = 1;
> } else if (dev->dev_flags & PHYLIB_FORCE_100) {
> dev->speed = SPEED_100;
> dev->duplex = DUPLEX_FULL;
> dev->autoneg = !AUTONEG_ENABLE;
> + dev->force = 1;
> + dev->link = 1;
> }
> }
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 1cf2cb9..12739ff 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -549,6 +549,10 @@ int genphy_read_status(struct phy_device *phydev)
> int lpa;
> int lpagb = 0;
>
> + /* if force the status and link are set */
> + if (phydev->force)
> + return 0;
> +
> /* Update the link, but return if there
> * was an error */
> err = genphy_update_link(phydev);
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 6c9cac9..99c9639 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -158,6 +158,7 @@ struct phy_device {
> u32 advertising;
>
> int autoneg;
> + int force;
>
>
> /* private data pointer */
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-25 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 9:34 Jean-Christophe PLAGNIOL-VILLARD
2013-02-25 7:55 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225075510.GJ1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox