[PATCH v2] menu: fix remove superfluous newline: change puts() -> printf("%s", )

[PATCH v2] menu: fix remove superfluous newline: change puts() -> printf("%s", )

[Fabio Porcedda]

Fix previous commit:
638f91b "fix compiler warnings: use puts() instead of printf()".

Because puts() function add a newline, use instead printf("%s", ).

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Vicente Bergas <vicencb@gmail.com>
---

Notes:
    v2:
     - corrected two typos in the description

 common/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/menu.c b/common/menu.c
index 30dced7..a672e59 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -274,7 +274,7 @@ int menu_show(struct menu *m)
 			printf("Auto Select in");
 		} else {
 			auto_display_len = strlen(m->auto_display);
-			puts(m->auto_display);
+			printf("%s", m->auto_display);
 		}
 		printf(" %2d", countdown--);
 	}
-- 
1.8.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2] menu: fix remove superfluous newline: change puts() -> printf("%s", )

[Sascha Hauer]

On Mon, Feb 25, 2013 at 05:46:48PM +0100, Fabio Porcedda wrote:
> Fix previous commit:
> 638f91b "fix compiler warnings: use puts() instead of printf()".
> 
> Because puts() function add a newline, use instead printf("%s", ).
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Vicente Bergas <vicencb@gmail.com>

Applied, thanks

Sascha

> ---
> 
> Notes:
>     v2:
>      - corrected two typos in the description
> 
>  common/menu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/menu.c b/common/menu.c
> index 30dced7..a672e59 100644
> --- a/common/menu.c
> +++ b/common/menu.c
> @@ -274,7 +274,7 @@ int menu_show(struct menu *m)
>  			printf("Auto Select in");
>  		} else {
>  			auto_display_len = strlen(m->auto_display);
> -			puts(m->auto_display);
> +			printf("%s", m->auto_display);
>  		}
>  		printf(" %2d", countdown--);
>  	}
> -- 
> 1.8.1.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox