From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 07/11] net/console: switch to pr_xxx
Date: Sat, 9 Mar 2013 11:19:03 +0100 [thread overview]
Message-ID: <20130309101903.GI1906@pengutronix.de> (raw)
In-Reply-To: <20130308174349.GJ32347@game.jcrosoft.org>
On Fri, Mar 08, 2013 at 06:43:49PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:25 Fri 08 Mar , Sascha Hauer wrote:
> > On Fri, Mar 08, 2013 at 12:59:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > > net/netconsole.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/net/netconsole.c b/net/netconsole.c
> > > index 7d0f3f4..8db8356 100644
> > > --- a/net/netconsole.c
> > > +++ b/net/netconsole.c
> > > @@ -185,7 +185,7 @@ static int netconsole_init(void)
> > >
> > > ret = console_register(cdev);
> > > if (ret) {
> > > - printf("netconsole: registering failed with %s\n", strerror(-ret));
> > > + pr_err("netconsole: registering failed with %s\n", strerror(-ret));
> >
> > Same comment as I already made: Please use pr_fmt
> can you apply the other one
>
> I'll resend just this one
Fixed this myself.
Sascha
>
> Best Regards,
> J.
> >
> > Sascha
> >
> > --
> > Pengutronix e.K. | |
> > Industrial Linux Solutions | http://www.pengutronix.de/ |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-09 10:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 21:54 [PATCH 00/11 v6] introduction of dmesg support Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 8:05 ` Jan Lübbe
2013-03-08 11:59 ` [PATCH 01/11] kfifo: introduce kfifo_dump_str to dump the fifo Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 02/11] console: switch to kfifo_dump_str Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 03/11] intoduce dmesg to print the barebox printk to dmesg ring buffer Jean-Christophe PLAGNIOL-VILLARD
2013-03-09 10:25 ` Sascha Hauer
2013-03-08 11:59 ` [PATCH 04/11] startup: switch to pr_xxx Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 05/11] at91: clock switch to pr_info Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 06/11] meminfo: switch to pr_xxx Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 07/11] net/console: " Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 17:25 ` Sascha Hauer
2013-03-08 17:43 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-09 10:19 ` Sascha Hauer [this message]
2013-03-08 11:59 ` [PATCH 08/11] startup: " Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 09/11] barebox_banner: switch to pr_info Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 10/11] net/phy: convert " Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 11:59 ` [PATCH 11/11] ext4: switch debug and printf to dev_xxx Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309101903.GI1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox