From: Sascha Hauer <s.hauer@pengutronix.de>
To: Vicente Bergas <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] ArchosG9: add keyboard input and new reset menu entries
Date: Mon, 11 Mar 2013 22:45:13 +0100 [thread overview]
Message-ID: <20130311214513.GP1906@pengutronix.de> (raw)
In-Reply-To: <1362958567-6110-5-git-send-email-vicencb@gmail.com>
On Mon, Mar 11, 2013 at 12:36:07AM +0100, Vicente Bergas wrote:
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> arch/arm/boards/archosg9/board.c | 25 +++++++++++++++++++++++
> arch/arm/boards/archosg9/env/bin/init | 28 ++++++++++++++++++++++++++
> arch/arm/boards/archosg9/env/boot/usb-android | 2 +-
> arch/arm/boards/archosg9/env/boot/usb-linux | 2 +-
> arch/arm/boards/archosg9/env/menu/mainmenu | 29 +++++++++++++++++++++++++++
> arch/arm/configs/archosg9_defconfig | 11 ++++++----
> 6 files changed, 91 insertions(+), 6 deletions(-)
> create mode 100644 arch/arm/boards/archosg9/env/bin/init
> create mode 100644 arch/arm/boards/archosg9/env/menu/mainmenu
>
> diff --git a/arch/arm/boards/archosg9/board.c b/arch/arm/boards/archosg9/board.c
> index bf247de..edeb871 100644
> --- a/arch/arm/boards/archosg9/board.c
> +++ b/arch/arm/boards/archosg9/board.c
> @@ -20,6 +20,9 @@
> #include <sizes.h>
> #include <i2c/i2c.h>
> #include <gpio.h>
> +#include <gpio_keys.h>
> +#include <twl6030_pwrbtn.h>
> +#include <readkey.h>
> #include "archos_features.h"
>
> static int archosg9_console_init(void){
> @@ -44,11 +47,33 @@ mem_initcall(archosg9_mem_init);
> static struct i2c_board_info i2c_devices[] = {
> { I2C_BOARD_INFO("twl6030", 0x48), },
> };
> +#ifdef CONFIG_KEYBOARD_TWL6030
> +static struct twl6030_pwrbtn_platform_data pwrbtn_data = {
> + .code = KEY_ENTER
> +};
> +#endif
> +#ifdef CONFIG_KEYBOARD_GPIO
> +static struct gpio_keys_button keys[] = {
> + { .code = KEY_UP , .gpio = 43, .active_low = 1 },
> + { .code = KEY_DOWN, .gpio = 44, .active_low = 1 },
> +};
> +static struct gpio_keys_platform_data gk_data = {
> + .buttons = keys,
> + .nbuttons = ARRAY_SIZE(keys),
> +};
> +#endif
>
> static int archosg9_devices_init(void){
> i2c_register_board_info(0, i2c_devices, ARRAY_SIZE(i2c_devices));
> omap44xx_add_i2c1(NULL);
> omap44xx_add_mmc1(NULL);
> +#ifdef CONFIG_KEYBOARD_TWL6030
> + add_generic_device_res("twl6030_pwrbtn", DEVICE_ID_DYNAMIC, 0, 0,
> + &pwrbtn_data);
> +#endif
> +#ifdef CONFIG_KEYBOARD_GPIO
> + add_gpio_keys_device(DEVICE_ID_DYNAMIC, &gk_data);
> +#endif
If you are not really really concerned about binary size I suggest to
drop the ifdefs. It makes for better readability.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-11 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 23:36 [PATCH 0/4] " Vicente Bergas
2013-03-10 23:36 ` [PATCH 1/4] gpio_keys: detect keys pressed before booting Vicente Bergas
2013-03-10 23:36 ` [PATCH 2/4] twl6030: add power button as an input key Vicente Bergas
2013-03-11 21:35 ` Sascha Hauer
2013-03-10 23:36 ` [PATCH 3/4] OMAP4: add command to select next boot device priority Vicente Bergas
2013-03-11 21:42 ` Sascha Hauer
2013-03-10 23:36 ` [PATCH 4/4] ArchosG9: add keyboard input and new reset menu entries Vicente Bergas
2013-03-11 21:45 ` Sascha Hauer [this message]
2013-03-12 0:09 ` vj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311214513.GP1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox