From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: i.MX: Add bbu handler for external NAND boot
Date: Tue, 12 Mar 2013 11:05:18 +0100 [thread overview]
Message-ID: <20130312100518.GQ1906@pengutronix.de> (raw)
In-Reply-To: <201303121048.16318.jbe@pengutronix.de>
On Tue, Mar 12, 2013 at 10:48:16AM +0100, Juergen Beisert wrote:
> Sascha Hauer wrote:
> > [...]
> > + if (size_available < 0) {
> > + printf("device is too small\n");
> > + ret = -ENOSPC;
> > + goto out;
> > + }
> > [...]
>
> As the user only sees bad block info when DEBUG is enabled, you should output
> more info here.
> The device (or better partition?) can be too small in general, or it can be
> too small due to many bad blocks inside. IMHO it would be helpful to see more
> info here why it failed.
Ok. I reworded this to:
printf("device is too small.\n"
"raw partition size: 0x%08llx\n"
"partition size w/o bad blocks: 0x%08llx\n"
"size needed: 0x%08x\n",
s.st_size,
s.st_size - num_bb * blocksize,
data->len);
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-12 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 9:29 [PATCH] fix i.MX external NAND boot bad block handling Sascha Hauer
2013-03-12 9:29 ` [PATCH 1/4] ARM: i.MX: external nand boot: check for bad blocks Sascha Hauer
2013-03-12 9:29 ` [PATCH 2/4] ARM: head: Add some space behind the image header Sascha Hauer
2013-03-12 9:41 ` Juergen Beisert
2013-03-12 9:29 ` [PATCH 3/4] ARM: i.MX: Add bbu handler for external NAND boot Sascha Hauer
2013-03-12 9:48 ` Juergen Beisert
2013-03-12 10:05 ` Sascha Hauer [this message]
2013-03-12 10:08 ` Juergen Beisert
2013-03-12 9:29 ` [PATCH 4/4] ARM: i.MX pcm043: register external nand boot handler Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312100518.GQ1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox