From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: i.MX: Add bbu handler for external NAND boot
Date: Tue, 12 Mar 2013 10:48:16 +0100 [thread overview]
Message-ID: <201303121048.16318.jbe@pengutronix.de> (raw)
In-Reply-To: <1363080597-10510-4-git-send-email-s.hauer@pengutronix.de>
Sascha Hauer wrote:
> [...]
> + if (size_available < 0) {
> + printf("device is too small\n");
> + ret = -ENOSPC;
> + goto out;
> + }
> [...]
As the user only sees bad block info when DEBUG is enabled, you should output
more info here.
The device (or better partition?) can be too small in general, or it can be
too small due to many bad blocks inside. IMHO it would be helpful to see more
info here why it failed.
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-12 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 9:29 [PATCH] fix i.MX external NAND boot bad block handling Sascha Hauer
2013-03-12 9:29 ` [PATCH 1/4] ARM: i.MX: external nand boot: check for bad blocks Sascha Hauer
2013-03-12 9:29 ` [PATCH 2/4] ARM: head: Add some space behind the image header Sascha Hauer
2013-03-12 9:41 ` Juergen Beisert
2013-03-12 9:29 ` [PATCH 3/4] ARM: i.MX: Add bbu handler for external NAND boot Sascha Hauer
2013-03-12 9:48 ` Juergen Beisert [this message]
2013-03-12 10:05 ` Sascha Hauer
2013-03-12 10:08 ` Juergen Beisert
2013-03-12 9:29 ` [PATCH 4/4] ARM: i.MX pcm043: register external nand boot handler Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303121048.16318.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox