From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UFLqD-0001LR-H3 for barebox@lists.infradead.org; Tue, 12 Mar 2013 09:49:54 +0000 From: Juergen Beisert Date: Tue, 12 Mar 2013 10:48:16 +0100 References: <1363080597-10510-1-git-send-email-s.hauer@pengutronix.de> <1363080597-10510-4-git-send-email-s.hauer@pengutronix.de> In-Reply-To: <1363080597-10510-4-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201303121048.16318.jbe@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/4] ARM: i.MX: Add bbu handler for external NAND boot To: barebox@lists.infradead.org Sascha Hauer wrote: > [...] > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (size_available < 0) { > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pri= ntf("device is too small\n"); > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ret= =3D -ENOSPC; > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0got= o out; > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0} > [...] As the user only sees bad block info when DEBUG is enabled, you should outp= ut = more info here. The device (or better partition?) can be too small in general, or it can be = too small due to many bad blocks inside. IMHO it would be helpful to see mo= re = info here why it failed. jbe -- = Pengutronix e.K. | Juergen Beisert = | Linux Solutions for Science and Industry | http://www.pengutronix.de/ = | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox