mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "antonynpavlov@gmail.com" <antonynpavlov@gmail.com>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 08/10] tegra: add generic debug UART support
Date: Thu, 11 Apr 2013 00:44:41 +0400	[thread overview]
Message-ID: <20130411004441.b4868f5b934c3ab4c40a107d@gmail.com> (raw)
In-Reply-To: <1365585481.1951.2.camel@antimon>

On Wed, 10 Apr 2013 11:18:01 +0200
Lucas Stach <dev@lynxeye.de> wrote:

> Am Montag, den 08.04.2013, 17:03 +0400 schrieb antonynpavlov@gmail.com:
> > On Mon, 08 Apr 2013 14:24:06 +0200
> > Lucas Stach <dev@lynxeye.de> wrote:
> > 
> > > Am Montag, den 08.04.2013, 15:46 +0400 schrieb antonynpavlov@gmail.com:
> > > > On Mon, 08 Apr 2013 12:57:26 +0200
> > > > Lucas Stach <dev@lynxeye.de> wrote:
> > > > 
> > > > > Hi Antony,
> > > > > 
> > > > > Am Freitag, den 05.04.2013, 00:32 +0400 schrieb antonynpavlov@gmail.com:
> > > > > > On Tue,  2 Apr 2013 08:19:10 +0200
> > > > > > Lucas Stach <dev@lynxeye.de> wrote:
> > > > > > 
> > > > > > > ODMdata tells us which UART to use for debugging purposes. This is
> > > > > > > agreed upon in both the upstream Linux kernel and U-Boot, so do it the
> > > > > > > same way in barebox.
> > > > > > 
> > > > > > This patch disables serial console on my Toshiba AC100.
> > > > > > 
> > > > > Hm that's unfortunate, but I already suspected that your ODMdata might
> > > > > be wrong.
> > > > > What happens if you don't remove the serial init in your board? Do you
> > > > > get a duplicate serial, or just your board defined one? If it still
> > > > > works for you this way, we might take this as a compromise for now.
> > > > 
> > > > IMHO, the right way is to get of_serial.c from linux and put some records 
> > > > like this 
> > > >  uarta: serial@70006000 {
> > > >                 compatible = "nvidia,tegra20-uart";
> > > >                 reg = <0x70006000 0x40>;
> > > >                 reg-shift = <2>;
> > > >                 interrupts = <0 36 0x04>;
> > > >                 nvidia,dma-request-selector = <&apbdma 8>;
> > > >                 clocks = <&tegra_car 6>;
> > > >                 status = "disabled";
> > > >   };
> > > > 
> > > > to arch/arm/dts/tegra20.dtsi.
> > > > 
> > > 
> > > No, this doesn't help with the decision which UART barebox should use
> > > for it's output. This is a configuration option and therefore not
> > > allowed to reside in the DT, so NVIDIA decided to put this information
> > > into the ODMdata. Both U-Boot and the Linux kernel(for earlyconsole) use
> > > the information stored in this location.
> > > 
> > > You can always activate more consoles from board code or DT, but the
> > > first/debug console should IMHO be handled the same way it's done in
> > > Linux.
> > 
> > Yes, this doesn't help to select the console UART, but it provide  the
> > information about platform available UARTs.
> > The selection of console port is board-dependent (e.g. the chip can have
> > many UARTs, but the board can use only one of them), so let's move this
> > selection to board configuration section.
> > 
> > Moreother, Toshiba AC100 is a netbook (or smartbook :), in normal mode it
> > use keyboard and LCD screen for user interaction, not UART.
> > 
> The generic serial patch in the series v4 now introduces a Kconfig to
> override the ODMdata value. I folded in the right config into the ac100
> defconfig, so this patch should no longer break your console.
> 
> Also I fixed a bug that may lead to wrong ODMdata console detection, so
> could you please test if it maybe also works with the automatic
> detection for you now?

I have just checked your patches with
 CONFIG_TEGRA_UART_ODMDATA=y
and with
 CONFIG_TEGRA_UART_A=y

Both configurations work fine!

There is a very small issues (see my next messages), but IMHO, the patches are ready for commiting.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-04-10 20:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02  6:19 Lucas Stach
2013-04-02  6:19 ` [PATCH v3 01/10] tegra: pull in iomap.h from the Linux kernel Lucas Stach
2013-04-02  6:19 ` [PATCH v3 02/10] tegra: define TEGRA20 arch type Lucas Stach
2013-04-02 13:09   ` Antony Pavlov
2013-04-04 20:43   ` antonynpavlov
2013-04-02  6:19 ` [PATCH v3 03/10] tegra: switch to DT only Lucas Stach
2013-04-02 11:42   ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-04 20:39   ` antonynpavlov
2013-04-02  6:19 ` [PATCH v3 04/10] tegra: add driver for the clock and reset module Lucas Stach
2013-04-02  6:19 ` [PATCH v3 05/10] tegra: add T20 timer driver Lucas Stach
2013-04-02  6:19 ` [PATCH v3 06/10] tegra: add T20 power management controller driver Lucas Stach
2013-04-02  6:19 ` [PATCH v3 07/10] tegra: add common lowlevel startup Lucas Stach
2013-04-02  6:19 ` [PATCH v3 08/10] tegra: add generic debug UART support Lucas Stach
2013-04-04 20:32   ` antonynpavlov
2013-04-08 10:57     ` Lucas Stach
2013-04-08 11:46       ` antonynpavlov
2013-04-08 12:24         ` Lucas Stach
2013-04-08 13:03           ` antonynpavlov
2013-04-08 13:34             ` Lucas Stach
2013-04-10  9:18             ` Lucas Stach
2013-04-10 20:44               ` antonynpavlov [this message]
2013-04-02  6:19 ` [PATCH v3 09/10] tegra: add generic meminit Lucas Stach
2013-04-02  6:19 ` [PATCH v3 10/10] tegra: add GPIO controller driver Lucas Stach
2013-04-08  3:51   ` antonynpavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411004441.b4868f5b934c3ab4c40a107d@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=dev@lynxeye.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox