From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Weitzel <j.weitzel@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] omap4-fb: use uncached screen_base
Date: Fri, 12 Apr 2013 17:03:53 +0200 [thread overview]
Message-ID: <20130412150353.GR1906@pengutronix.de> (raw)
In-Reply-To: <1365679699-4475-1-git-send-email-j.weitzel@phytec.de>
Hi Jan,
On Thu, Apr 11, 2013 at 01:28:19PM +0200, Jan Weitzel wrote:
> If the buffer is cached the image on the LCD is broken. Only some small
> lines on the last rows. Flushing the cache "repairs" the image.
>
> Is remap_range the right way to get a non cached buffer?
I think using this is ok for now, at least when the driver is ARM
specific, which the omap fb driver is. We do not have a propert API
for this kind of stuff and I currently have no idea how such an API
would look like.
You should make sure though that pdata->screen->start and the screen
size are page aligned.
> This patch only covers prealloc_screen, not dynamic
> If the buffer is dynamic, is the use of dma_alloc_coherent right?
correct.
> Or should
> the buffer remaped again if freed?
ideally it should, at least when the screen is passed via platform data.
Anyway, when you pass it via platform_data then you normally do it to
preserve the screen during kernel start, so I wouldn't free it in this
case.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-04-12 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 11:28 Jan Weitzel
2013-04-12 15:03 ` Sascha Hauer [this message]
2013-04-15 12:20 ` Alexander Aring
2013-04-15 11:45 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412150353.GR1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=j.weitzel@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox