From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 7.mo3.mail-out.ovh.net ([46.105.57.200] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUHTt-0001FJ-U2 for barebox@lists.infradead.org; Mon, 22 Apr 2013 14:12:34 +0000 Received: from mail432.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 17D65FF8F82 for ; Mon, 22 Apr 2013 16:03:39 +0200 (CEST) Date: Mon, 22 Apr 2013 15:59:08 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20130422135908.GB13393@game.jcrosoft.org> References: <1366439718-31495-1-git-send-email-shc_work@mail.ru> <20130420165900.GE32215@game.jcrosoft.org> <1366622000.671448158@f347.mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1366622000.671448158@f347.mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] clocksource: Add pointer to clocksource structure in read function To: Alexander Shiyan Cc: barebox@lists.infradead.org On 13:13 Mon 22 Apr , Alexander Shiyan wrote: > > On 10:35 Sat 20 Apr , Alexander Shiyan wrote: > > > > > > This patch adds pointer to clocksource structure in read function. > > > For avoid name collisions, clocksource names for all drivers was > > > changed to be unique. > > why? > > > > no need the clocksource is hot path don't touch it > > and we do not need the struct pointer as we can have only 1 cs in barebox > > This change allows to add an additional field in struct clocksource then > we can remove static variables from clocksource drivers. why we have only one clocksource at a time what you propose will require to use container_of so will slow down a lot barebox Best Regards, J. > > --- _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox