From: Sascha Hauer <s.hauer@pengutronix.de>
To: Uladzimir Bely <u.bely@sam-solutions.com>
Cc: barebox@lists.infradead.org, Uladzimir Bely <u.bely@sam-solutions.net>
Subject: Re: [PATCH] ARM: OMAP5 processors support
Date: Wed, 24 Apr 2013 22:11:27 +0200 [thread overview]
Message-ID: <20130424201127.GG32299@pengutronix.de> (raw)
In-Reply-To: <1366799600-10058-1-git-send-email-u.bely@sam-solutions.com>
On Wed, Apr 24, 2013 at 01:33:20PM +0300, Uladzimir Bely wrote:
> From: Uladzimir Bely <u.bely@sam-solutions.net>
>
> +
> +static struct NS16550_plat serial_plat = {
> + .clock = 48000000, /* 48MHz (APLL96/2) */
> + .shift = 2,
> +};
> +
> +static int omap5_sevm_console_init(void)
> +{
> + /* Register the serial port */
> + add_ns16550_device(DEVICE_ID_DYNAMIC, OMAP54XX_UART3_BASE, 1024,
> + IORESOURCE_MEM_8BIT, &serial_plat);
We have convenience wrappers for omap3/4 (omap3_add_uartx). Would be
nice to get them for omap5 aswell.
> diff --git a/arch/arm/boards/omap5_sevm/config.h b/arch/arm/boards/omap5_sevm/config.h
> new file mode 100644
> index 0000000..da84fa5
> --- /dev/null
> +++ b/arch/arm/boards/omap5_sevm/config.h
> @@ -0,0 +1 @@
> +/* nothing */
> diff --git a/arch/arm/boards/omap5_sevm/env/config b/arch/arm/boards/omap5_sevm/env/config
> new file mode 100644
> index 0000000..9752957
> --- /dev/null
> +++ b/arch/arm/boards/omap5_sevm/env/config
> @@ -0,0 +1,11 @@
> +#!/bin/sh
> +
> +machine=omap5
> +
> +autoboot_timeout=2
> +
> +bootargs="console=ttyO2,115200"
> +
> +kernel_loc=disk
> +
> +PS1="\e[1;32mbarebox@\e[1;31m\h:\w\e[0m "
> +#define CM_WKUPAON_KBD_CLKCTRL_OFT 0x0078
> +#define CM_WKUPAON_SCRM_CLKCTRL_OFT 0x0090
> +#define CM_WKUPAON_IO_SRCOMP_CLKCTRL_OFT 0x0098
> +
> +/* CKGEN_CM_CORE_AON Registers */
> +#define CM_BASE 0x4a004100
Please add at least to the base addresses a proper OMAP5_ prefix.
> +struct s32ktimer {
> + unsigned char res[0x10];
> + unsigned int s32k_cr;
> +};
This is unused.
Much of the code looks quite famliar from the omap4 port. Isn't there
more code sharing possible?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-04-24 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <014261>
2013-04-24 10:33 ` Uladzimir Bely
2013-04-24 10:51 ` Uladzimir Bely
2013-04-24 20:11 ` Sascha Hauer [this message]
2013-04-25 9:09 ` Uladzimir Bely
2013-04-25 11:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-25 11:58 ` Jan Lübbe
2013-04-25 12:42 ` Uladzimir Bely
2013-04-25 20:47 ` Sascha Hauer
2013-04-26 8:31 ` Jan Lübbe
[not found] ` <517A57F8.8020805@sam-solutions.net>
2013-04-26 10:54 ` Jan Lübbe
2013-04-26 10:59 ` Uladzimir Bely
2013-04-26 21:58 ` Sascha Hauer
2013-04-25 13:31 ` menon.nishanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424201127.GG32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.bely@sam-solutions.com \
--cc=u.bely@sam-solutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox