From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd-core: fix mtd erase operation for non-uniform flashes.
Date: Thu, 23 May 2013 15:27:49 +0200 [thread overview]
Message-ID: <20130523132749.GQ32299@pengutronix.de> (raw)
In-Reply-To: <1369241656-9219-1-git-send-email-renaud.barbier@ge.com>
On Wed, May 22, 2013 at 05:54:16PM +0100, Renaud Barbier wrote:
> This patch supports the erasing of CFI flash with non-uniform sector.
> When more than one erase region exists, the mtd_erasesize function
> assigns the erase size of the sector to the erase_info structure.
>
> The problem was discovered when erasing /dev/env0 on my PPC board.
> This is a partition of size 0x8000 at offset 0 of a 32MB Intel compatible
> flash with a bottom boot block i.e 4 32KB sectors followed by 255
> 128KB sectors.
>
> barebox> unprotect /dev/env0
> barebox> erase /dev/env0
> cfi_erase: start = 0x0, end = 0x3, count = 0x20000
> Flash erase error at address fe008000
> Block Erase Error.
> Block locked.
> erase: I/O error
>
> The error above is that a count of 0x20000 is passed instead of 0x8000
> by mtd_op_erase. This is because the code does not take into account
> multiple erase regions.
>
> After taking into account the erase regions, only the first sector is
> erased:
>
> barebox> unprotect /dev/env0
> barebox> erase /dev/env0
> cfi_erase: start = 0x0, end = 0x0, count = 0x8000
>
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-05-23 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 16:54 Renaud Barbier
2013-05-23 13:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523132749.GQ32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox