From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC, PATCH v2 1/3] MIPS: add Atheros ar531x family support
Date: Thu, 23 May 2013 15:35:45 +0200 [thread overview]
Message-ID: <20130523133545.GR32299@pengutronix.de> (raw)
In-Reply-To: <1369208989-14369-2-git-send-email-linux@rempel-privat.de>
Hi Oleksij,
On Wed, May 22, 2013 at 09:49:47AM +0200, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> +
> +/*
> + * This table is indexed by bits 5..4 of the CLOCKCTL1 register
> + * to determine the predevisor value.
> + */
> +static int CLOCKCTL1_PREDIVIDE_TABLE[4] = { 1, 2, 4, 5 };
> +
> +static unsigned int
> +ar2312_cpu_frequency(void)
> +{
> + unsigned int predivide_mask, predivide_shift;
> + unsigned int multiplier_mask, multiplier_shift;
> + unsigned int clockCtl1, preDivideSelect, preDivisor, multiplier;
No CamelCase please.
> +static int platform_init(void)
> +{
> + add_generic_device("ar2312_reset", DEVICE_ID_SINGLE, NULL,
> + KSEG1ADDR(AR2312_RESETTMR), 0x4,
> + IORESOURCE_MEM, NULL);
> + watchdog_init();
> + flash_init();
> + ether_init();
Whether or not the flash/ethernet/serial device is available is board
specific, not SoC specific, so this should be done in board code. It's
good to provide helpers to make this simple for the board code though,
so a good option would be to add a SoC prefix to the functions and call
it from board code.
Otherwise I am fine with this patch, but maybe Antony still has some
comments.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-05-23 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 7:49 [RFC, PATCH v2 0/3] work on atheros ar2313 Oleksij Rempel
2013-05-22 7:49 ` [RFC, PATCH v2 1/3] MIPS: add Atheros ar531x family support Oleksij Rempel
2013-05-23 13:35 ` Sascha Hauer [this message]
2013-05-23 13:43 ` Oleksij Rempel
2013-05-22 7:49 ` [RFC, PATCH v2 2/3] net: add ar231x-eth support Oleksij Rempel
2013-05-24 7:09 ` Sascha Hauer
2013-05-24 9:14 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-25 15:57 ` Oleksij Rempel
2013-05-28 6:57 ` Sascha Hauer
2013-05-22 7:49 ` [RFC, PATCH v2 3/3] MIPS: ar231x: add netgear-wg102 Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523133545.GR32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox