* [PATCH] scripts: Makefile: do not use obj-* variables for userspace tools
@ 2013-05-28 9:39 Jan Luebbe
2013-05-30 10:14 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Jan Luebbe @ 2013-05-28 9:39 UTC (permalink / raw)
To: barebox
When using obj-?, it erroneously tries to link a built-in.o. Instead
use the extra-? variable.
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
scripts/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile b/scripts/Makefile
index f062fc0..e375530 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -30,7 +30,7 @@ subdir- += basic kconfig setupmbr
quiet_cmd_csingle = CC $@
cmd_csingle = $(CC) -Wp,-MD,$(depfile) $(CFLAGS) -o $@ $<
-obj-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
+extra-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
scripts/bareboxenv-target: scripts/bareboxenv.c FORCE
$(call if_changed_dep,csingle)
--
1.8.2.rc2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts: Makefile: do not use obj-* variables for userspace tools
2013-05-28 9:39 [PATCH] scripts: Makefile: do not use obj-* variables for userspace tools Jan Luebbe
@ 2013-05-30 10:14 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-05-30 10:14 UTC (permalink / raw)
To: Jan Luebbe; +Cc: barebox
On Tue, May 28, 2013 at 11:39:44AM +0200, Jan Luebbe wrote:
> When using obj-?, it erroneously tries to link a built-in.o. Instead
> use the extra-? variable.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Applied, thanks
Sascha
> ---
> scripts/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile b/scripts/Makefile
> index f062fc0..e375530 100644
> --- a/scripts/Makefile
> +++ b/scripts/Makefile
> @@ -30,7 +30,7 @@ subdir- += basic kconfig setupmbr
> quiet_cmd_csingle = CC $@
> cmd_csingle = $(CC) -Wp,-MD,$(depfile) $(CFLAGS) -o $@ $<
>
> -obj-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
> +extra-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
>
> scripts/bareboxenv-target: scripts/bareboxenv.c FORCE
> $(call if_changed_dep,csingle)
> --
> 1.8.2.rc2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-30 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-28 9:39 [PATCH] scripts: Makefile: do not use obj-* variables for userspace tools Jan Luebbe
2013-05-30 10:14 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox