* [PATCH] Remove a redundant line.
@ 2013-06-02 12:59 Masaki Muranaka
2013-06-02 13:13 ` Alexander Shiyan
2013-06-03 7:26 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Masaki Muranaka @ 2013-06-02 12:59 UTC (permalink / raw)
To: barebox
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
---
commands/echo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/commands/echo.c b/commands/echo.c
index 8929234..4dfd870 100644
--- a/commands/echo.c
+++ b/commands/echo.c
@@ -55,7 +55,6 @@ static int do_echo(int argc, char *argv[])
break;
case 'o':
oflags |= O_TRUNC;
- file = argv[optind + 1];
if (optind + 1 < argc)
file = argv[optind + 1];
else
--
1.8.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove a redundant line.
2013-06-02 12:59 [PATCH] Remove a redundant line Masaki Muranaka
@ 2013-06-02 13:13 ` Alexander Shiyan
2013-06-03 7:26 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Shiyan @ 2013-06-02 13:13 UTC (permalink / raw)
To: Masaki Muranaka; +Cc: barebox
> Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
> ---
> commands/echo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/commands/echo.c b/commands/echo.c
> index 8929234..4dfd870 100644
> --- a/commands/echo.c
> +++ b/commands/echo.c
> @@ -55,7 +55,6 @@ static int do_echo(int argc, char *argv[])
> break;
> case 'o':
> oflags |= O_TRUNC;
> - file = argv[optind + 1];
> if (optind + 1 < argc)
> file = argv[optind + 1];
> else
> --
Nice catch. This is a possible crash.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove a redundant line.
2013-06-02 12:59 [PATCH] Remove a redundant line Masaki Muranaka
2013-06-02 13:13 ` Alexander Shiyan
@ 2013-06-03 7:26 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2013-06-03 7:26 UTC (permalink / raw)
To: Masaki Muranaka; +Cc: barebox
On Sun, Jun 02, 2013 at 09:59:05PM +0900, Masaki Muranaka wrote:
> Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Applied, thanks
Sascha
> ---
> commands/echo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/commands/echo.c b/commands/echo.c
> index 8929234..4dfd870 100644
> --- a/commands/echo.c
> +++ b/commands/echo.c
> @@ -55,7 +55,6 @@ static int do_echo(int argc, char *argv[])
> break;
> case 'o':
> oflags |= O_TRUNC;
> - file = argv[optind + 1];
> if (optind + 1 < argc)
> file = argv[optind + 1];
> else
> --
> 1.8.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-02 12:59 [PATCH] Remove a redundant line Masaki Muranaka
2013-06-02 13:13 ` Alexander Shiyan
2013-06-03 7:26 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox