From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UjscR-0007ai-CV for barebox@lists.infradead.org; Tue, 04 Jun 2013 14:53:52 +0000 Date: Tue, 4 Jun 2013 16:53:27 +0200 From: Sascha Hauer Message-ID: <20130604145327.GJ32299@pengutronix.de> References: <1369741903-24988-2-git-send-email-j.weitzel@phytec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1369741903-24988-2-git-send-email-j.weitzel@phytec.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] OMAP4: Use default clock source for mcbsp To: Jan Weitzel Cc: barebox@lists.infradead.org Hi Jan, On Tue, May 28, 2013 at 01:51:40PM +0200, Jan Weitzel wrote: > In omap4_enable_all_clocks we not only enable the mcbsp clocks, but also > change the source from ABE_24M_FCLK to 24M_FCLK. Revert this and default > to the reset state. Can you add a description why this is necessary? Sascha > > Signed-off-by: Jan Weitzel > --- > arch/arm/mach-omap/omap4_clock.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap/omap4_clock.c b/arch/arm/mach-omap/omap4_clock.c > index 0621fd3..889d1f9 100644 > --- a/arch/arm/mach-omap/omap4_clock.c > +++ b/arch/arm/mach-omap/omap4_clock.c > @@ -253,9 +253,9 @@ void omap4_enable_all_clocks(void) > sr32(CM1_ABE_PDM_CLKCTRL, 0, 32, 0x2); > sr32(CM1_ABE_DMIC_CLKCTRL, 0, 32, 0x2); > sr32(CM1_ABE_MCASP_CLKCTRL, 0, 32, 0x2); > - sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x08000002); > - sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x08000002); > - sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x08000002); > + sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x2); > + sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x2); > + sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x2); > sr32(CM1_ABE_SLIMBUS_CLKCTRL, 0, 32, 0xf02); > sr32(CM1_ABE_TIMER5_CLKCTRL, 0, 32, 0x2); > sr32(CM1_ABE_TIMER6_CLKCTRL, 0, 32, 0x2); > -- > 1.7.0.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox