From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v6] omap4-fb: add driver
Date: Mon, 17 Jun 2013 09:36:47 +0200 [thread overview]
Message-ID: <20130617073647.GJ32299@pengutronix.de> (raw)
In-Reply-To: <1371222662.28854.15.camel@mars>
Hi Christoph,
Some small comments, then we shoulf be good to go.
On Fri, Jun 14, 2013 at 05:11:02PM +0200, Christoph Fritz wrote:
> This patch adds omap4 display controller support.
>
> index 94e42c6..e70ddbd 100644
> --- a/arch/arm/mach-omap/Makefile
> +++ b/arch/arm/mach-omap/Makefile
> @@ -28,6 +28,7 @@ obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
> pbl-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
> obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
> obj-$(CONFIG_SHELL_NONE) += xload.o
> +obj-$(CONFIG_DRIVER_VIDEO_OMAP4) += omap4_fb.o
Please compile this in unconditionally. Otherwise board using this have
to add a dependency on CONFIG_DRIVER_VIDEO_OMAP4 aswell.
> +struct device_d *omap4_add_display(void *pdata)
Let this function take a struct omap4fb_platform_data *. This makes it
more clear how to call it.
> +static void omap4fb_enable(struct fb_info *info)
> +{
> + struct omap4fb_device *fbi =
> + container_of(info, struct omap4fb_device, info);
You could add a static inline to_omap4fb function. It's less error prone
and the above would fit into a single line.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-17 7:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 6:42 [PATCH] " Christoph Fritz
2013-04-05 8:59 ` Sascha Hauer
2013-04-07 22:15 ` [PATCH v2] " Christoph Fritz
2013-04-08 7:17 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-09 7:16 ` Sascha Hauer
2013-04-09 13:29 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-11 19:01 ` Christoph Fritz
2013-06-02 21:07 ` Christoph Fritz
2013-06-12 20:45 ` [PATCH v3] " Christoph Fritz
2013-06-13 10:10 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-13 22:40 ` [PATCH v4] " Christoph Fritz
2013-06-14 6:29 ` Alexander Aring
2013-06-14 7:23 ` Jan Weitzel
2013-06-14 8:15 ` [PATCH v5] " Christoph Fritz
2013-06-14 11:43 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-14 15:11 ` [PATCH v6] " Christoph Fritz
2013-06-17 7:36 ` Sascha Hauer [this message]
2013-06-17 16:17 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-18 8:47 ` [PATCH v7] " Christoph Fritz
2013-06-17 18:45 ` [PATCH v6] " Alexander Aring
2013-06-17 16:18 ` Christoph Fritz
2013-06-18 7:41 ` Tomi Valkeinen
2013-06-18 8:09 ` Christoph Fritz
2013-06-18 9:59 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617073647.GJ32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=chf.fritz@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox