From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpB6Y-00014T-3p for barebox@lists.infradead.org; Wed, 19 Jun 2013 05:38:51 +0000 Date: Wed, 19 Jun 2013 07:38:27 +0200 From: Sascha Hauer Message-ID: <20130619053827.GF32299@pengutronix.de> References: <1371559850-21867-1-git-send-email-jlu@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1371559850-21867-1-git-send-email-jlu@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] devfs-core: introduce devfs_append_partition To: Jan Luebbe Cc: barebox@lists.infradead.org On Tue, Jun 18, 2013 at 02:50:50PM +0200, Jan Luebbe wrote: > This simplifies board code for partition setup by keeping track of the > offset. > > Signed-off-by: Jan Luebbe Good idea. There seem to be some bugs in this area. I'm fine with the patch when some users are converted to this. Sascha > --- > fs/devfs-core.c | 9 +++++++++ > include/driver.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/fs/devfs-core.c b/fs/devfs-core.c > index 262e0a2..f7d79ff 100644 > --- a/fs/devfs-core.c > +++ b/fs/devfs-core.c > @@ -267,6 +267,15 @@ int devfs_add_partition(const char *devname, loff_t offset, loff_t size, > return 0; > } > > +int devfs_append_partition(const char *devname, loff_t *offset, loff_t size, > + int flags, const char *name) > +{ > + int ret; > + ret = devfs_add_partition(devname, *offset, size, flags, name); > + *offset += size; > + return ret; > +} > + > int devfs_del_partition(const char *name) > { > struct cdev *cdev; > diff --git a/include/driver.h b/include/driver.h > index 716f792..3f4f7b9 100644 > --- a/include/driver.h > +++ b/include/driver.h > @@ -463,6 +463,8 @@ int cdev_erase(struct cdev *cdev, size_t count, loff_t offset); > > int devfs_add_partition(const char *devname, loff_t offset, loff_t size, > int flags, const char *name); > +int devfs_append_partition(const char *devname, loff_t *offset, loff_t size, > + int flags, const char *name); > int devfs_del_partition(const char *name); > > #define DRV_OF_COMPAT(compat) \ > -- > 1.8.3.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox