From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UsGnJ-0007wo-P4 for barebox@lists.infradead.org; Thu, 27 Jun 2013 18:19:47 +0000 Date: Thu, 27 Jun 2013 20:19:23 +0200 From: Sascha Hauer Message-ID: <20130627181923.GH516@pengutronix.de> References: <1372152047-28134-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130627065118.GA10414@pengutronix.de> <51CBEEB2.5090209@gmail.com> <20130627085816.GF516@pengutronix.de> <51CBFF3E.6090306@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51CBFF3E.6090306@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/9] OF: address and device related sync and cleanup To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org On Thu, Jun 27, 2013 at 11:00:46AM +0200, Sebastian Hesselbarth wrote: > On 06/27/13 10:58, Sascha Hauer wrote: > >On Thu, Jun 27, 2013 at 09:50:10AM +0200, Sebastian Hesselbarth wrote: > >>On 06/27/13 08:51, Sascha Hauer wrote: > >>>Applied this series with the change that I removed the dead code > >>>ifdeffed with CONFIG_PPC_DCR. > >> > >>Ok, great! Next patch sets will be focused on actually using the > >>DT improvements. I have an SPI driver for MACH_MVEBU ready and > >>running, and I am working on importing generic SDHCI from Linux. > > > >The sdhc driver in Linux is a big piece of shit which uses the wrong > >abstraction model. This is shown by the fact that 32bits are not enough > >to abstract the quirks. Even with all these quirks the i.MX part of this > >driver has to implement driver logic in the register access functions. > >That just insane. I'm not really looking forward to add this driver > >to barebox. > > Ok, fair enough. Then I'll be adding the required callbacks to Dove > SDHCI driver directly based on current barebox i.MX driver. I think for the SDHC a library approach would be good: Add a new driver and share common code/helper functions. I recently factored out the register defines as a start so that these can be shared. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox