From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 0/2] serial: ns16550: small dt support improvements
Date: Thu, 25 Jul 2013 12:28:51 +0400 [thread overview]
Message-ID: <20130725122851.21230bc159c293a28acaa7b6@gmail.com> (raw)
In-Reply-To: <20130724165421.GS9434@pengutronix.de>
On Wed, 24 Jul 2013 18:54:21 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Tue, Jul 23, 2013 at 07:28:00PM +0400, Antony Pavlov wrote:
> > [RFC 1/2] serial: ns16550: get clock-frequency from dt
> > [RFC 2/2] serial: ns16550: fill cdev just-in-time
>
> Applied, thanks.
>
> I assume the second one is only cosmetic, right?
Yes, it's mostly cosmetic: the main goal of the second patch
is making code more "easy-to-understand".
As a bonus you get a tiny insignificant optimisation: if there is any error
during probe then there is no need in cdev and cdev can
be keeped unitialized (tut IMHO a smart compiler can make itself
a reposition like this :).
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-07-25 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 15:28 Antony Pavlov
2013-07-23 15:28 ` [RFC 1/2] serial: ns16550: get clock-frequency from dt Antony Pavlov
2013-07-23 15:28 ` [RFC 2/2] serial: ns16550: fill cdev just-in-time Antony Pavlov
2013-07-24 16:54 ` [RFC 0/2] serial: ns16550: small dt support improvements Sascha Hauer
2013-07-25 8:28 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725122851.21230bc159c293a28acaa7b6@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox