From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 8/8] fs: Add ubifs support
Date: Tue, 6 Aug 2013 21:50:10 +0200 [thread overview]
Message-ID: <20130806195010.GE26614@pengutronix.de> (raw)
In-Reply-To: <20130806181614.GA30507@x61s.8.8.8.8>
Hi Alex,
On Tue, Aug 06, 2013 at 08:16:16PM +0200, Alexander Aring wrote:
> Hi Sascha,
>
> I take only a fast first look, it's a nice pretty huge patch :-)
>
Yes, it's huge. Unfortunately not only in source code size, but also in
binary size...
> > obj-$(CONFIG_FS_NFS) += nfs.o
> > diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
> > new file mode 100644
> > index 0000000..76612fd
> > --- /dev/null
> > +++ b/fs/ubifs/Kconfig
> > @@ -0,0 +1,17 @@
> > +menuconfig FS_UBIFS
> > + bool
>
> select UBI here?
> We use sometimes the ubi_read function.
Yes, right. I'll add a depends on CONFIG_MTD_UBI instead. selecting it
is not good since UBI needs mtd which would introduce indirect
dependencies.
> > + bool
> > + select LZO_DECOMPRESS
> > + prompt "LZO compression support"
> > +
> > +config FS_UBIFS_COMPRESSION_ZLIB
> > + bool
> > + select ZLIB
> > + prompt "ZLIB compression support"
> > +
> > +endif
>
> Is this for a full compressed ubi volume? I know that in ubifs exists
> some extended attributes to enable compression for a special file. How
> barebox deal with that? I think barebox hasn't a support for xattr yet. :(
The compression in UBIFS comes from UBIFS, not from UBI. See mkfs.ubifs -h,
you can specify different compression types.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-08-06 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 13:07 [PATCH] UBIFS support Sascha Hauer
2013-08-06 13:07 ` [PATCH 1/8] mtd: ubi: add missing prototype for ubi_volume_notify Sascha Hauer
2013-08-06 13:07 ` [PATCH 2/8] mtd: ubi: add ubi info functions Sascha Hauer
2013-08-06 13:07 ` [PATCH 3/8] filetype: Add ubifs detection Sascha Hauer
2013-08-06 13:07 ` [PATCH 4/8] mtd: ubi: Add support for opening a volume by cdev Sascha Hauer
2013-08-06 13:07 ` [PATCH 5/8] move print_hex_dump function to include/common.h Sascha Hauer
2013-08-06 13:07 ` [PATCH 6/8] extend barebox wrapper header Sascha Hauer
2013-08-06 13:07 ` [PATCH 7/8] Add deflate_decompress function Sascha Hauer
2013-08-06 13:07 ` [PATCH 8/8] fs: Add ubifs support Sascha Hauer
2013-08-06 18:16 ` Alexander Aring
2013-08-06 19:50 ` Sascha Hauer [this message]
2013-08-06 23:50 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806195010.GE26614@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox