mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Revert "ARM: Use armlinux_bootparams address for DTB"
Date: Wed, 7 Aug 2013 14:40:54 +0200	[thread overview]
Message-ID: <20130807124054.GF2911@lukather> (raw)
In-Reply-To: <1375877184.576122343@f176.i.mail.ru>


[-- Attachment #1.1: Type: text/plain, Size: 1526 bytes --]

On Wed, Aug 07, 2013 at 04:06:24PM +0400, Alexander Shiyan wrote:
> > On Wed, Aug 07, 2013 at 01:55:42PM +0400, Alexander Shiyan wrote:
> > > > This patch placed the flattened devicetree to armlinux_bootparams.
> > > > armlinux_bootparams normally is at SDRAM_START + 0x100. The kernels
> > > > initial page tables are normally at SDRAM_START + 0x4000, so the
> > > > flattened devicetree gets overwritten once it exceeds 0x3f00 bytes
> > > > which is quite common.
> > > > 
> > > > Revert this patch for now once a better solution can be found
> > > 
> > > In such a case, tree may be placed immediately after the kernel?
> > > It can also serve as an automatic option "ARM_APPENDED_DTB".
> > 
> > That won't work either, since the DTB will be overwritten by the kernel
> > decompressor.
> 
> arch/arm/Kconfig:
> ...
> config ARM_APPENDED_DTB
> 	bool "Use appended device tree blob to zImage (EXPERIMENTAL)"
> 	depends on OF && !ZBOOT_ROM
> 	help
> 	  With this option, the boot code will look for a device tree binary
> 	  (DTB) appended to zImage
> 	  (e.g. cat zImage <filename>.dtb > zImage_w_dtb).
> ...
> 
> So, DTB is placed immediately after the kernel.

Yes, in the case where you have APPENDED_DTB, the decompressor relocates
the DTB before doing the decompression.

The trouble is when you don't have APPENDED_DTB enabled, when there is
no such relocation happening.

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-08-07 12:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07  9:45 Sascha Hauer
2013-08-07  9:55 ` Alexander Shiyan
2013-08-07 10:11   ` Sascha Hauer
2013-08-07 10:34     ` Alexander Shiyan
2013-08-08  7:17       ` Alexander Shiyan
2013-08-09  6:58         ` Sascha Hauer
2013-08-09  7:02           ` Alexander Shiyan
2013-08-09  8:02             ` Sascha Hauer
2013-08-07 11:37   ` Maxime Ripard
2013-08-07 12:06     ` Alexander Shiyan
2013-08-07 12:40       ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807124054.GF2911@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox