Re: [PATCH 3/6] ARM: mvebu: introduce multi image support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Aug 13, 2013 at 03:30:38PM +0200, Sebastian Hesselbarth wrote:
> On 08/13/13 09:26, Sascha Hauer wrote:
> >diff --git a/arch/arm/boards/solidrun-cubox/lowlevel.c b/arch/arm/boards/solidrun-cubox/lowlevel.c
> >new file mode 100644
> >index 0000000..fdf5a7e
> >--- /dev/null
> >+++ b/arch/arm/boards/solidrun-cubox/lowlevel.c
> >@@ -0,0 +1,37 @@
> [...]
> >+ENTRY_FUNCTION(start_solidrun_cubox)(void)
> >+{
> >+	uint32_t fdt;
> >+
> >+	__barebox_arm_head();
> >+
> >+	arm_cpu_lowlevel_init();
> >+
> >+	fdt = (uint32_t)__dtb_dove_cubox_start - get_runtime_offset();
> >+
> >+	mvebu_barebox_entry(fdt);
> >+}
> [...]
> > diff --git a/arch/arm/mach-mvebu/lowlevel.c
> b/arch/arm/mach-mvebu/lowlevel.c
> > index 3f64c4a..11810cc 100644
> > --- a/arch/arm/mach-mvebu/lowlevel.c
> > +++ b/arch/arm/mach-mvebu/lowlevel.c
> > @@ -24,5 +24,5 @@
> >   void __naked barebox_arm_reset_vector(void)
> >   {
> >   	arm_cpu_lowlevel_init();
> > -	mvebu_barebox_entry();
> > +	mvebu_barebox_entry(0);
> >   }
> 
> Sascha,
> 
> thanks for the patch set, I'll give it a go soon.
> 
> I understand that this is just a first step, but you are adding extra
> lowlevel init to boards/solidrun-cubox/lowlevel.c but in the end it
> should be part of mach-mvebu/lowlevel.c instead?
> 
> I have a some MVEBU boards with Dove and Armada 370 available and
> could extend the patches to have a single lowlevel init again.

The board specific lowlevel init is necessary since this specifies the
dtb to use. Otherwise there's no way to find out on which board you are
running on.

(Another possibility would be to somehow append a devicetree, but I
haven't found a good way to do that)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox