From: Sascha Hauer <s.hauer@pengutronix.de>
To: Shravan Kumar <shravan.k@phytec.in>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: omap: barebox update spi nor MLO handler
Date: Fri, 23 Aug 2013 08:46:02 +0200 [thread overview]
Message-ID: <20130823064602.GG31036@pengutronix.de> (raw)
In-Reply-To: <1377173137-27320-1-git-send-email-shravan.k@phytec.in>
Hi Shravan,
On Thu, Aug 22, 2013 at 02:05:36PM +0200, Shravan Kumar wrote:
> From: shravan <shravan.k@phytec.in>
>
> -Added mlo spi NOR copy handler
> -This handler will convert the MLO to big endian
> -Tested with pcm051 board
>
> +/*
> + * Register a omap MLO update handler for SPI NOR
> + */
> +int omap_bbu_spi_nor_mlo_register_handler(const char *name, char *devicefile)
> +{
Does this work with "real" omaps? The comment in the header seems to
imply that it only works for am33xx. If this is the case, the function
should be named am33xx_bbu_spi_nor_mlo_register_handler.
Otherwise this series looks fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-08-23 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:05 Shravan Kumar
2013-08-22 12:05 ` [PATCH 2/2] PCM051: Added barebox update SPI NOR " Shravan Kumar
2013-08-23 6:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823064602.GG31036@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shravan.k@phytec.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox