From: Jason Cooper <jason@lakedaemon.net>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 1/8] ARM: add very initial support for Canon DIGIC chips
Date: Mon, 26 Aug 2013 21:46:48 -0400 [thread overview]
Message-ID: <20130827014648.GA15429@titan.lakedaemon.net> (raw)
In-Reply-To: <521BE5A1.5080109@gmail.com>
On Tue, Aug 27, 2013 at 01:32:49AM +0200, Sebastian Hesselbarth wrote:
> On 08/26/2013 09:47 PM, Jason Cooper wrote:
> >On Mon, Aug 26, 2013 at 10:51:48PM +0400, Antony Pavlov wrote:
> >>On Mon, 26 Aug 2013 09:20:18 -0400
> >>Jason Cooper <jason@lakedaemon.net> wrote:
> >>>On Mon, Aug 26, 2013 at 08:57:10AM +0400, Antony Pavlov wrote:
> >>>>+/* Serial interface registers */
> >>>>+#define DEBUG_LL_UART_TX (DEBUG_LL_UART + 0x0)
> >>>>+#define DEBUG_LL_UART_ST (DEBUG_LL_UART + 0x14)
> >>>>+ #define UART_ST_TX_RDY 2
> >>>
> >>>leading whitespace, and perhaps use BIT() here.
> >>
> >>The leading whitespace is put here intentionally to distinguish register address macros
> >>and bit fields macros.
> >
> >CodingStyle doesn't spell it out explicitly, however:
> >
> >$ git grep -c '^[ \t]#define'
>
> Jason,
>
> you should have used
>
> git grep -c '^#[ \t]define'
>
> It is in fact quite common to distinguish address offset macros
> and bit macros by adding a space, but between '#' and 'define'.
fair enough, I'll admit it's a personal bias. :-P I like everything
lined up vertically so that differences from line to line stand out
more. But that's just me, and it's not my code, so I'll drop it.
thx,
Jason.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-08-27 1:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 4:57 [RFC 0/8] barebox on Canon cameras: serial console and dts support Antony Pavlov
2013-08-26 4:57 ` [RFC 1/8] ARM: add very initial support for Canon DIGIC chips Antony Pavlov
2013-08-26 13:20 ` Jason Cooper
2013-08-26 18:51 ` Antony Pavlov
2013-08-26 19:47 ` Jason Cooper
2013-08-26 23:32 ` Sebastian Hesselbarth
2013-08-27 1:46 ` Jason Cooper [this message]
2013-08-27 4:57 ` Antony Pavlov
2013-08-27 7:00 ` Jürgen Beisert
2013-08-26 4:57 ` [RFC 2/8] serial: add driver for Canon DIGIC UART Antony Pavlov
2013-08-26 13:28 ` Jason Cooper
2013-08-26 4:57 ` [RFC 3/8] gpio: add driver for Canon DIGIC Antony Pavlov
2013-08-26 4:57 ` [RFC 4/8] ARM: DIGIC: add Canon PowerShot A1100 IS support Antony Pavlov
2013-08-26 4:57 ` [RFC 5/8] ARM: DIGIC: add canon-a1100_defconfig Antony Pavlov
2013-08-26 4:57 ` [RFC 6/8] ARM: DIGIC: add csrc-dummy Antony Pavlov
2013-08-26 4:57 ` [RFC 7/8] ARM: DIGIC: add Canon EOS 600D support Antony Pavlov
2013-08-26 4:57 ` [RFC 8/8] ARM: DIGIC: add canon-600d_defconfig Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827014648.GA15429@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox