From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VE8ND-0006Jm-DS for barebox@lists.infradead.org; Tue, 27 Aug 2013 01:47:13 +0000 Date: Mon, 26 Aug 2013 21:46:48 -0400 From: Jason Cooper Message-ID: <20130827014648.GA15429@titan.lakedaemon.net> References: <1377493037-2229-1-git-send-email-antonynpavlov@gmail.com> <1377493037-2229-2-git-send-email-antonynpavlov@gmail.com> <20130826132018.GF13964@titan.lakedaemon.net> <20130826225148.789cb51a803900ceb21f77ae@gmail.com> <20130826194758.GC24470@titan.lakedaemon.net> <521BE5A1.5080109@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <521BE5A1.5080109@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC 1/8] ARM: add very initial support for Canon DIGIC chips To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org On Tue, Aug 27, 2013 at 01:32:49AM +0200, Sebastian Hesselbarth wrote: > On 08/26/2013 09:47 PM, Jason Cooper wrote: > >On Mon, Aug 26, 2013 at 10:51:48PM +0400, Antony Pavlov wrote: > >>On Mon, 26 Aug 2013 09:20:18 -0400 > >>Jason Cooper wrote: > >>>On Mon, Aug 26, 2013 at 08:57:10AM +0400, Antony Pavlov wrote: > >>>>+/* Serial interface registers */ > >>>>+#define DEBUG_LL_UART_TX (DEBUG_LL_UART + 0x0) > >>>>+#define DEBUG_LL_UART_ST (DEBUG_LL_UART + 0x14) > >>>>+ #define UART_ST_TX_RDY 2 > >>> > >>>leading whitespace, and perhaps use BIT() here. > >> > >>The leading whitespace is put here intentionally to distinguish register address macros > >>and bit fields macros. > > > >CodingStyle doesn't spell it out explicitly, however: > > > >$ git grep -c '^[ \t]#define' > > Jason, > > you should have used > > git grep -c '^#[ \t]define' > > It is in fact quite common to distinguish address offset macros > and bit macros by adding a space, but between '#' and 'define'. fair enough, I'll admit it's a personal bias. :-P I like everything lined up vertically so that differences from line to line stand out more. But that's just me, and it's not my code, so I'll drop it. thx, Jason. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox