From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 6.mo4.mail-out.ovh.net ([188.165.36.253] helo=mo4.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VGsZX-0002YV-HM for barebox@lists.infradead.org; Tue, 03 Sep 2013 15:31:16 +0000 Received: from mail638.ha.ovh.net (gw6.ovh.net [213.251.189.206]) by mo4.mail-out.ovh.net (Postfix) with SMTP id 492F9106CA1A for ; Tue, 3 Sep 2013 17:30:53 +0200 (CEST) Date: Tue, 3 Sep 2013 17:31:48 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20130903153148.GC22507@ns203013.ovh.net> References: <7CB5E6E6-CC40-418F-ADB6-766DEC5D180A@reinrag.net> <20130903113942.GA22507@ns203013.ovh.net> <1E234F4F-BB0B-4144-9D85-C7975D686F50@reinrag.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1E234F4F-BB0B-4144-9D85-C7975D686F50@reinrag.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/4] AT91: move have_intensity_bit into board setup To: Darren Garnier Cc: barebox@lists.infradead.org On 09:34 Tue 03 Sep , Darren Garnier wrote: > > On Sep 3, 2013, at 7:39 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 22:22 Mon 02 Sep , Darren Garnier wrote: > >> Signed-off-by: Darren Garnier > > \why this is soc specific > > Yes, the option is probably soc specific, but in the 9261 soc, we actually have 2 cpus. Both the 9261 and 9g10. > One of the few differences between these pin compatible chips is the way the LCD peripheral is wired. > > My board has 2 varieties out in the wild.. one with the 9261 and the other with the 9g10 and because of the > way they are wired, the "intensity bit" is only appropriate to the 9261 cpu board. Since you can't change this setting easily after you pass it off > to at91_add_device_lcdc, it's important that it only be set in the board file. > I need to check the datasheet but I'm enarly sure this is not board specific but SoC > > > > > Best Regards, > > J. > >> --- > >> arch/arm/boards/at91sam9261ek/init.c | 2 ++ > >> arch/arm/mach-at91/at91sam9261_devices.c | 2 -- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/boards/at91sam9261ek/init.c b/arch/arm/boards/at91sam9261ek/init.c > >> index 00fc745..b420a48 100644 > >> --- a/arch/arm/boards/at91sam9261ek/init.c > >> +++ b/arch/arm/boards/at91sam9261ek/init.c > >> @@ -223,6 +223,8 @@ static void ek_add_device_lcdc(void) > >> > >> if (machine_is_at91sam9g10ek()) > >> ek_lcdc_data.lcd_wiring_mode = ATMEL_LCDC_WIRING_RGB; > >> + else > >> + ek_lcdc_data.has_intensity_bit = true; > >> > >> at91_add_device_lcdc(&ek_lcdc_data); > >> } > >> diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c > >> index b522afb..ba52e56 100644 > >> --- a/arch/arm/mach-at91/at91sam9261_devices.c > >> +++ b/arch/arm/mach-at91/at91sam9261_devices.c > >> @@ -218,8 +218,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_platform_data *data) > >> { > >> BUG_ON(!data); > >> > >> - data->have_intensity_bit = true; > >> - > >> #if defined(CONFIG_FB_ATMEL_STN) > >> at91_set_A_periph(AT91_PIN_PB0, 0); /* LCDVSYNC */ > >> at91_set_A_periph(AT91_PIN_PB1, 0); /* LCDHSYNC */ > >> -- > >> 1.8.3.1 > >> > >> > >> > >> _______________________________________________ > >> barebox mailing list > >> barebox@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/barebox > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox