From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: qemu-malta: switch to devicetree
Date: Wed, 4 Sep 2013 08:30:13 +0200 [thread overview]
Message-ID: <20130904063013.GF30088@pengutronix.de> (raw)
In-Reply-To: <20130903112156.GL19197@ns203013.ovh.net>
On Tue, Sep 03, 2013 at 01:21:56PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:41 Tue 03 Sep , Antony Pavlov wrote:
> > On Tue, 3 Sep 2013 08:33:33 +0400
> > > -static struct NS16550_plat serial_plat = {
> > > - .clock = 1843200, /* no matter for emulated port */
> > > - .shift = 0,
> > > -};
> > > -
> > > -static int malta_console_init(void)
> > > -{
> > > - barebox_set_model("qemu malta");
> > > barebox_set_hostname("malta");
> > >
> >
> > May be it is reasonable to add hostname support to dts?
> >
> > The lonely barebox_set_hostname() in the malta board code looks very pathetically :)
>
> we could use the model propertie for this
The model property is already used for the verbose name of a board. I
described it as:
/*
* The model is the verbose name of a board. It can contain
* whitespaces, uppercase/lowcer letters, digits, ',', '.'
* '-', '_'
*/
Whereas the hostname is without whitespaces, I described it as:
/*
* The hostname is supposed to be the shortname of a board. It should
* contain only lowercase letters, numbers, '-', '_'. No whitespaces
* allowed.
*/
I think it is reasonable to add a hostname property to the devicetree.
The last time I thought about this I couldn't really agree with myself
how to name it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-04 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 4:33 Antony Pavlov
2013-09-03 4:41 ` Antony Pavlov
2013-09-03 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-04 6:30 ` Sascha Hauer [this message]
2013-09-04 7:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-04 20:36 ` Sascha Hauer
2013-09-04 6:33 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904063013.GF30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox