Re: [PATCH] MIPS: qemu-malta: switch to devicetree

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 08:30 Wed 04 Sep     , Sascha Hauer wrote:
> On Tue, Sep 03, 2013 at 01:21:56PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 08:41 Tue 03 Sep     , Antony Pavlov wrote:
> > > On Tue,  3 Sep 2013 08:33:33 +0400
> > > > -static struct NS16550_plat serial_plat = {
> > > > -	.clock = 1843200, /* no matter for emulated port */
> > > > -	.shift = 0,
> > > > -};
> > > > -
> > > > -static int malta_console_init(void)
> > > > -{
> > > > -	barebox_set_model("qemu malta");
> > > >  	barebox_set_hostname("malta");
> > > >
> > > 
> > > May be it is reasonable to add hostname support to dts?
> > > 
> > > The lonely barebox_set_hostname() in the malta board code looks very pathetically :)
> > 
> > we could use the model propertie for this
> 
> The model property is already used for the verbose name of a board. I
> described it as:
> 
> /*
>  * The model is the verbose name of a board. It can contain
>  * whitespaces, uppercase/lowcer letters, digits, ',', '.'
>  * '-', '_'
>  */
> 
> Whereas the hostname is without whitespaces, I described it as:
> 
> /*
>  * The hostname is supposed to be the shortname of a board. It should
>  * contain only lowercase letters, numbers, '-', '_'. No whitespaces
>  * allowed.
>  */
> 
> I think it is reasonable to add a hostname property to the devicetree.
> The last time I thought about this I couldn't really agree with myself
> how to name it.
how about use the compatible property?

for me I'll just put
model = "toto toto toto" , "toto_toot_toto";

if no second string create a hotname on the fly by replace the forbidden char
by '_'

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox