[PATCH / RFC] MCI: imx-esdhc: implement workaround for errata ENGcm12360

[PATCH / RFC] MCI: imx-esdhc: implement workaround for errata ENGcm12360

[Markus Niebel]

From: Markus Niebel <Markus.Niebel@tqs.de>

Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>

At least i.MX53 has errata ENGcm12360:

Occurs when a pending command which issues busy is completed.
For a command with R1b response, the proper software sequence
is to poll the DLA for R1b commands to determine busy
state completion. The DLA polling is not working properly for
the ESDHC module. This is relevant for all eSDHC ports (eSDHC1-4 ports)

DLA bit in PRSSTAT register cannot be
polled to wait for busy state completion.

Updated block guide to reflect that DLA is not applicable to detect
busy state, instead, should poll bit 24 in PRSSTAT register (DLSL[0] bit)
to check that wait busy state is over.
---
 drivers/mci/imx-esdhc.c |   21 +++++++++++++++++++++
 drivers/mci/sdhci.h     |    1 +
 2 files changed, 22 insertions(+)

diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
index 8cf3e64..902c654 100644
--- a/drivers/mci/imx-esdhc.c
+++ b/drivers/mci/imx-esdhc.c
@@ -266,6 +266,27 @@ esdhc_send_cmd(struct mci_host *mci, struct mci_cmd *cmd, struct mci_data *data)
 	if (irqstat & IRQSTAT_CTOE)
 		return -ETIMEDOUT;
 
+	/* Workaround for ESDHC errata ENGcm03648 / ENGcm12360 */
+	if (!data && (cmd->resp_type & MMC_RSP_BUSY)) {
+		/* 
+		 * use high timeout value - we saw card failures here
+		 * using 250 msec in u-boot 2013.04 / i.MX6
+		 */
+		#define DAT0_POLL_TIME 2500
+
+		/* 
+		 * Poll on DATA0 line for cmd with busy signal for 
+		 * timout / 10 usec since DLA polling can be insecure
+		 */
+		ret = wait_on_timeout(DAT0_POLL_TIME * MSECOND,
+			(esdhc_read32(regs + SDHCI_PRESENT_STATE) & PRSSTAT_DAT0));
+
+		if (ret) {
+			dev_err(host->dev, "timeout PRSSTAT_DAT0\n");
+			return -ETIMEDOUT;
+		}
+	}
+
 	/* Copy the response to the response buffer */
 	if (cmd->resp_type & MMC_RSP_136) {
 		u32 cmdrsp3, cmdrsp2, cmdrsp1, cmdrsp0;
diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
index b2d6779..4302095 100644
--- a/drivers/mci/sdhci.h
+++ b/drivers/mci/sdhci.h
@@ -75,6 +75,7 @@
 #define IRQSTATEN_TC		0x00000002
 #define IRQSTATEN_CC		0x00000001
 
+#define PRSSTAT_DAT0		0x01000000
 #define PRSSTAT_CLSL		0x00800000
 #define PRSSTAT_WPSPL		0x00080000
 #define PRSSTAT_CDPL		0x00040000
-- 
1.7.9.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH / RFC] MCI: imx-esdhc: implement workaround for errata ENGcm12360

[Sascha Hauer]

Hi Markus,

On Thu, Sep 05, 2013 at 03:31:20PM +0200, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tqs.de>
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
> 
> At least i.MX53 has errata ENGcm12360:
> 
> Occurs when a pending command which issues busy is completed.
> For a command with R1b response, the proper software sequence
> is to poll the DLA for R1b commands to determine busy
> state completion. The DLA polling is not working properly for
> the ESDHC module. This is relevant for all eSDHC ports (eSDHC1-4 ports)
> 
> DLA bit in PRSSTAT register cannot be
> polled to wait for busy state completion.
> 
> Updated block guide to reflect that DLA is not applicable to detect
> busy state, instead, should poll bit 24 in PRSSTAT register (DLSL[0] bit)
> to check that wait busy state is over.

I'll give it a try in the -next branch. The patch looks as if it is safe
on other SoCs, but let's see.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox