From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VLUFK-0004vX-Jz for barebox@lists.infradead.org; Mon, 16 Sep 2013 08:33:27 +0000 Date: Mon, 16 Sep 2013 10:33:04 +0200 From: Sascha Hauer Message-ID: <20130916083304.GW30088@pengutronix.de> References: <20130915112850.GC21829@ns203013.ovh.net> <1379244654-30716-1-git-send-email-plagnioj@jcrosoft.com> <1379244654-30716-2-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1379244654-30716-2-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/4] login: disable input console if password wrong To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Sun, Sep 15, 2013 at 01:30:52PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > so we guarantee that barebox is secured again user interaction > > +static bool console_input_allow = false; > + > +static int console_input_allow_set(struct device_d *dev, struct param_d *p, const char *val) > +{ > + int ret = dev_param_set_generic(dev, p, val); > + > + if (val && simple_strtoul(val, NULL, 10)) > + console_input_allow = true; > + else > + console_input_allow = false; > + > + return ret; > +} > + > +static int console_global_init(void) > +{ > + globalvar_add("console.input_allow", console_input_allow_set, NULL, 0); > + > + if (IS_ENABLED(CONFIG_CMD_LOGIN) && is_passwd_enable()) > + setenv("global.console.input_allow", "0"); > + else > + setenv("global.console.input_allow", "1"); > + > + return 0; > +} > +late_initcall(console_global_init); With the attached patch applied the above would go down to: static int console_input_allow; static int console_global_init(void) { dev_add_param_bool(&global_device, "console.input_allow", NULL, NULL, &console_input_allow, NULL); return 0; } late_initcall(console_global_init); 8<---------------------------------------------------------------------- >From ae4a37fce8637280751fa75a58ea658b61c3a190 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Mon, 16 Sep 2013 10:17:26 +0200 Subject: [PATCH] globalvar: Make global_device global This makes global_device accessible globally so that global variables of a certain type can be added with dev_add_param_* Signed-off-by: Sascha Hauer --- common/globalvar.c | 2 +- include/globalvar.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/common/globalvar.c b/common/globalvar.c index edb66dd..6ef4a6a 100644 --- a/common/globalvar.c +++ b/common/globalvar.c @@ -6,7 +6,7 @@ #include #include -static struct device_d global_device = { +struct device_d global_device = { .name = "global", .id = DEVICE_ID_SINGLE, }; diff --git a/include/globalvar.h b/include/globalvar.h index c2a13b3..a9d01d4 100644 --- a/include/globalvar.h +++ b/include/globalvar.h @@ -2,6 +2,9 @@ #define __GLOBALVAR_H #include +#include + +extern struct device_d global_device; #ifdef CONFIG_GLOBALVAR int globalvar_add_simple(const char *name, const char *value); -- 1.8.4.rc3 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox