From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 08/11] ARM: socfpga: Add FPGA programming command
Date: Mon, 16 Sep 2013 13:43:56 +0200 [thread overview]
Message-ID: <20130916114356.GC16832@pengutronix.de> (raw)
In-Reply-To: <20130916110914.GZ30088@pengutronix.de>
On Mon, Sep 16, 2013 at 01:09:14PM +0200, Sascha Hauer wrote:
> Hi Steffen,
>
> On Mon, Sep 16, 2013 at 12:40:41PM +0200, Steffen Trumtrar wrote:
> > Hi!
> >
> > On Mon, Sep 16, 2013 at 10:48:17AM +0200, Sascha Hauer wrote:
> > > This adds a simple socfpga specific 'fpga' command to load a firmware
> > > to the FPGA. For the moment this is enough, but should we get more
> > > FPGA support it might be a good idea to introduce some generic framework
> > > and command.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > > arch/arm/mach-socfpga/Kconfig | 5 +
> > > arch/arm/mach-socfpga/Makefile | 1 +
> > > arch/arm/mach-socfpga/fpga.c | 422 ++++++++++++++++++++++
> > > arch/arm/mach-socfpga/include/mach/socfpga-regs.h | 2 +
> > > 4 files changed, 430 insertions(+)
> > > create mode 100644 arch/arm/mach-socfpga/fpga.c
> > >
> >
> > Why did you chose to have an extra command for fpga loading instead of having
> > just a (block)device? Do you see any future advantage in that or is it just
> > because of the port from u-boot? I know that they need an extra fpga command, but
> > they also have an extra mmcload command and stuff.
>
> Main reason was that I was unsure how good a block device will be when
> we get a different firmware format to load (rbf vs. sof vs. something
> else)
>
Aha, okay. If we want/need to support different formats, than a special
command might be necessary. At least when the format is not easy to
autodetect, I guess.
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-16 11:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 8:48 [PATCH] Altera SoCFPGA support Sascha Hauer
2013-09-16 8:48 ` [PATCH 01/11] ARM: invalidate caches thoroughly Sascha Hauer
2013-09-16 8:48 ` [PATCH 02/11] clk: of: introduce of_clk_src_simple_get Sascha Hauer
2013-09-16 8:48 ` [PATCH 03/11] of: partition: Check for valid partition name Sascha Hauer
2013-09-16 8:48 ` [PATCH 04/11] serial: ns16550: Add compatible entry for snps, dw-apb-uart Sascha Hauer
2013-09-16 8:48 ` [PATCH 05/11] clk: Add Altera SoCFPGA clk support Sascha Hauer
2013-09-16 8:48 ` [PATCH 06/11] scripts: Add Altera SoCFPGA mkimage support Sascha Hauer
2013-09-16 8:48 ` [PATCH 07/11] ARM: Add Altera SoCFPGA support Sascha Hauer
2013-09-17 14:46 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-18 8:06 ` Sascha Hauer
2013-09-16 8:48 ` [PATCH 08/11] ARM: socfpga: Add FPGA programming command Sascha Hauer
2013-09-16 10:40 ` Steffen Trumtrar
2013-09-16 11:09 ` Sascha Hauer
2013-09-16 11:43 ` Steffen Trumtrar [this message]
2013-09-17 14:51 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-16 8:48 ` [PATCH 09/11] ARM: SoCFPGA: Add Terasic SoCkit board support Sascha Hauer
2013-09-17 14:49 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-16 8:48 ` [PATCH 10/11] ARM: SoCFPGA: Add EBV SoCrates " Sascha Hauer
2013-09-16 8:48 ` [PATCH 11/11] ARM: Altera SoCFPGA: Add defconfig files Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916114356.GC16832@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox