Re: [PATCH 1/4] misc: add bootcount framework

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Sep 23, 2013 at 10:05:40AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:33 Mon 23 Sep     , Sascha Hauer wrote:
> > On Sat, Sep 21, 2013 at 08:46:04AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Can we please just do something like:
> > 
> > common/bootcount.c:
> > 
> > static int bootcount;
> > 
> > /*
> >  * Call this with your actual boot count, already increased by one
> >  * for the current boot.
> >  */
> > int bootcount_set(int count)
> > {
> > 	if (bootcount) {
> > 		pr_err("Bootcount already set\n");
> > 		return -EINVAL;
> > 	}
> > 
> > 	bootcount = count;
> > 
> > 	return 0;
> > }
> > 
> > static int bootcount_init(void)
> > {
> > 	globalvar_add_simple_int_ro("bootcount", &bootcount, "%d");
> > 
> > 	return 0;
> > }
> > late_initcall(bootcount_init);
> 
> no as the bootcount is way more complex for somfy
> 
> we store the boot count in one register with the boot mode
> 
> and the boot count can we reset by the shell
> 
> so it's not a RO

Make it rw then.

Put whatever complexity you need into your somfy code, but all that's
user visible is a single variable (visible to both C code and
userspace). We don't need a framework for this.

> 
> and I do not like to put everything on global

And I do not like creating devices which serve only as a namespace
provider for variables.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox